React-native-calendars: Migrate from XDate to moment.js

[tautvilas]

Change underlying date implementation

[pinguinjkeke]

Will be PR accepted if I'll implement this? It 10 PRs almost there, idk how fast they are accepted

[tautvilas]

Hi, PRs are merged approx once a month. It also depends on quality of PR and responsiveness of author if it will be merged.

[pinguinjkeke]

Ok, it makes sense.
What about to use some linting tools? Do you like eslint airbnb preset?

[tautvilas]

The lint is configured use npm run lint command

[davidgoli]

I would strongly discourage this switchover. Moment.js, while popular, is infamously bloated (particularly due to its locales) and would be forcing adoption of an enormous dependency on end users. XDate is 3k gzipped, moment is 16.4k gzipped, and moment-with-locales is a whopping 66.3k gzipped!

[davidgoli]

Alternatives I would propose instead:

https://date-fns.org/
https://github.com/moment/luxon

Even better, providing props to consumers so we can provide our own date library or implementation without taking on another dependency!

[tautvilas]

@davidgoli thanks for update. I am also not sure if moment.js will bring more benefits so I am not sure about this refactor. I want to use date library that has immutable date objects, AFAIK neither XDate or Moment.js support this. This leads to various weird bugs.

Either way react-native-calendars exposes date objects that are time-library agnostic, so we can refactor anytime when good alternative lib appears.

[davidgoli]

@tautvilas both date-fns and luxon use immutable objects, for what it's worth.

[julioxavierr]

@goldenhammer @ethanshar @sibelius I like the idea of using date-fns and would like to contribute. Can I start working on it and see how it goes?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.