React-native-admob: React Native 0.40 Compatibility

[edencakir]

Is this repo supporting version 0.40?

[lucianomlima]

Not yet. But I send a PR that fix this. Wait for merge #78.

[fcpauldiaz]

What else is needed to support version 0.40?

[yoonjaepark]

Have you solved this problem? not supprot RN 0.4>= Version And react-native link commend?

[edencakir]

It looks like @lucianomlima solved the iOS part, so we're left with Android. Anyone can make this happen?

[fcpauldiaz]

I installed manually this on RN 0.40 and it worked with Android, I just changed the location of the interterstial id.

[lucianomlima]

@fcpauldiaz Location of interstitial on iOS or Android too?

[edencakir]

@fcpauldiaz @lucianomlima since sbugert seems inactive, can one of you test a working version of 0.40 and fork it? Others and future users can benefit from your work, since there seems to be no other admob repo.

[fcpauldiaz]

@lucianomlima only on Android, I haven't tested it on iOS. @edencakir I can do an example over the weekend. If someone needs an example right now, you can check my app repo just be careful with the production ads.

[lucianomlima]

@fcpauldiaz you can send me the code you change?
Maybe I try to update my pull request to fix compatibility for Android too.

[fcpauldiaz]

I based all my code from the Example from this repo. The lines that I actually changed are this, this, this, this and this.

And of course the versions of RN.

[lucianomlima]

@fcpauldiaz thanks, I've seen your code and apparently the interstitial issue is not directly related to the RN 0.40+ version.
So, maybe Android platform don't need adjusts for RN 0.40+.

[fcpauldiaz]

That's great! So you can make a release now

[lucianomlima]

Here in this repo I can't, cause I'm not collaborator.

[yoonjaepark]

i just typed commands.
version
"dependencies": {
"react": "15.4.2",
"react-native": "0.41.2",
"react-native-admob": "^1.1.5"
},

npm i react-native-admob -S
react-native link

pod install
target 'admob' do
  use_frameworks!
  pod 'Firebase/AdMob'

  target 'admobTests' do
    inherit! :search_paths

  end

end

Build fali since then. How do you solution with it?

[edencakir]

Do you have a working fork? @lucianomlima

[lucianomlima]

@YoonJaePark see #78 or use RN 0.39

[lucianomlima]

@edencakir my fork only have a branch with the changes I do in PR #78
Here I'm still using RN 0.39

[alvaromb]

Closed by #95

[alvaromb]

Published https://github.com/sbugert/react-native-admob/releases/tag/v1.2.0

Please feel free to ping me if anything is wrong.