We noticed that our implementation of Joyride does not scroll with when moving to steps that are further down the page.
We checked the demo page and it does not seem to be working either.
The Version of Chrome we are using is ; Version 61.0.3163.100 (Official Build) (64-bit)
I believe this is a very recent version of chrome so I wanted to have this checked early.
Verified. Auto scrolling is broken with latest chrome update (Version 61.0.3163.100 (Official Build) (64-bit))
Verified.
document.body.scrollTop assignment isn't working anymore in Chrome 61: https://stackoverflow.com/questions/45061901/chrome-61-body-doesnt-scroll
However document.scrollingElement.scrollTop assignment, included in Chrome 44, works:
https://developer.mozilla.org/pt-BR/docs/Web/API/document/scrollingElement
I think we can check document.scrollingElement prior to document.body to manage the scroll in non-IE browsers in .getRootEl() method.
Fixed in v1.11.0
I just updated to 1.11.0 and have scrollToSteps={true} and it is still not scrolling to the bottom of the page to the elements. Any ideas?
Have you validated it is broken in just Chrome and not all browsers? If
it's broken in other browsers it may be indicative of another problem.
On Wed, Nov 1, 2017 at 10:02 AM, Jen Duncan notifications@github.com
wrote:
I just updated to 1.11.0 and have scrollToSteps={true} and it is still not
scrolling to the bottom of the page to the elements. Any ideas?—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gilbarbara/react-joyride/issues/268#issuecomment-341132634,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFP5lTY3HlJHve4f9GhtGnGCnUVNMGnMks5syIgigaJpZM4PhGS4
.
--
Trevor
Is the step's element fixed? I can't say what's happening without viewing some code.
Most helpful comment
Fixed in v1.11.0