React-hot-loader: support React 15.5 deprecations

Created on 8 Apr 2017  路  3Comments  路  Source: gaearon/react-hot-loader

Description

Package currently still uses propTypes from react. As per [email protected] this has been deprecated and an external package can be used instead.

Expected behavior

Package functions as anticipated this is just an update that needs to be made to the code base to stay current with the react ecosystem.

Actual behavior

Following error message is showing in the browser console:
screen shot 2017-04-08 at 12 04 32 pm

Environment

React Hot Loader version:

"react-hot-loader": "3.0.0-beta.6",

Run these commands in the project folder and fill in their results:

  1. node -v: 7.7.2
  2. npm -v: 4.1.2

Then, specify:

  1. Operating system: MacOS Sierra 10.12.4
  2. Browser and version: Google Chrome Version 57.0.2987.133 (64-bit)

Opening a PR will reference Issue there and PR here.

Most helpful comment

Yeah, I think this needs to be re-opened. Seeing this as well and I think this is the last item that needs to be updated in my project(s) to use prop-types but its hard to tell because it doesn't tell you exactly where its being used still.

All 3 comments

Closing. I was mistake with the use of propTypes in the package. Issue was coming from redbox-react not this package.

I think this issue is still relevant since redbox-react is a dependency of react-hot-loader. The dependency should be upgraded to 1.3.6 to fix the warnings.

Yeah, I think this needs to be re-opened. Seeing this as well and I think this is the last item that needs to be updated in my project(s) to use prop-types but its hard to tell because it doesn't tell you exactly where its being used still.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jljorgenson18 picture jljorgenson18  路  3Comments

mtscout6 picture mtscout6  路  3Comments

mattkrick picture mattkrick  路  3Comments

Opty1712 picture Opty1712  路  4Comments

adesmet picture adesmet  路  4Comments