React-helmet: Deep comparing props in shouldComponentUpdate (usage with preact-compat)

Created on 30 May 2017  路  3Comments  路  Source: nfl/react-helmet

Hey there,

I don't know if usage with preact-compat is something this lib intends to support, so I'll just ask. =)

I opened this issue there: https://github.com/developit/preact-compat/issues/391

Is this something that could be fixed in react-helmet? Or should I just replace it with preact-helmet?

Thanks in advance!

picture bassarisse
👍4

Most helpful comment

I'm using react 16.3.* (without preact) and I have the problem.. One of the props in shouldComponentUpdate is object of FiberNode, and this object has recursive link to himself (alternate field) and so deepClone will be crashed..

picture kandebr on 4 Apr 2018
👍2

All 3 comments

This affects React-Static users who opt for preact. What's the game plan here?

tannerlinsley picture tannerlinsley on 5 Mar 2018

I'm using react 16.3.* (without preact) and I have the problem.. One of the props in shouldComponentUpdate is object of FiberNode, and this object has recursive link to himself (alternate field) and so deepClone will be crashed..

kandebr picture kandebr on 4 Apr 2018
👍2

react-fast-compare just added support for Preact in [email protected]. Maybe this could be resolved by upgrading the dependency?

esbenam picture esbenam on 11 May 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

brokentone picture brokentone  路  4Comments
lxe picture lxe  路  5Comments
aravind12345 picture aravind12345  路  5Comments
jineshmehta16 picture jineshmehta16  路  3Comments
bratva picture bratva  路  4Comments