React-helmet: Server-render - has unexpected comma in title

Created on 30 May 2017  路  4Comments  路  Source: nfl/react-helmet

Hello.

Server side render title tag has unexpected comma.

Expected on server My Site London.
Actually on server: My Site ,London.

On client - like expected.

Details:
server.js:

const {renderToString} = require('react-dom/server');
const {Helmet} = require('react-helmet');

serverRender() {
    const helmet = Helmet.renderStatic();

    return (
        ....
        ${helmet.title.toString()}
    );
}

client.js:

render() {
    // string
    const CITY = 'London'; 
    <Helmet>
        <title>My Site {CITY}</title>
    </Helmet>
}

dependences version

    "react": "^15.5.0",
    "react-dom": "^15.5.0",
    "react-helmet": "^5.1.3"

Most helpful comment

I'm still seeing this issue on 5.2.0?

All 4 comments

A temporary solution is:
client.js

render() {
    // string
    const CITY = 'London'; 
    const title = `My Site ${CITY}`;
    <Helmet>
        <title>{title}</title>
    </Helmet>
}

I'm still seeing this issue on 5.2.0?

Regression? Seeing this bug again

I'm seeing this bug client-side

Was this page helpful?
0 / 5 - 0 ratings

Related issues

brianespinosa picture brianespinosa  路  3Comments

sneridagh picture sneridagh  路  4Comments

lxe picture lxe  路  5Comments

tiagonapoli picture tiagonapoli  路  3Comments

namnm picture namnm  路  4Comments