React-dates: New Warning with last version 18.2.1
When I use your last DateRangePicker, I see in console this:
DateRangePicker has a method called shouldComponentUpdate(). shouldComponentUpdate should not be used when extending React.PureComponent. Please extend React.Component if shouldComponentUpdate is used. - react-dom.development.js:506
on every kind of interaction. I'm using last version of React and React-dom (16.6.1)
timhecker
All 7 comments
Ah I'm pretty sure this is due to the change I shipped yesterday. I will amend the babel transform to conditionally insert the shouldComponentUpdate. Thanks for letting me know! v18.2.0 should be fine.
majapw
on 7 Nov 2018
This is also happening with SingleDatePicker as well.
LeHaine
on 7 Nov 2018
Any updates on this?
Dodie324
on 7 Nov 2018
Just put a fix up! :) I'll merge and republish once I verify it and tests pass.
majapw
on 8 Nov 2018
Doing a release now!
majapw
on 8 Nov 2018
18.2.2 is out!
majapw
on 8 Nov 2018
Thanks!
timhecker
on 8 Nov 2018
Related issues
krissalvador27
路
3Comments
aaronvanston
路
3Comments
swaritkohli
路
3Comments
cemremengu
路
3Comments
Adam-Pendleton
路
3Comments
Most helpful comment
Ah I'm pretty sure this is due to the change I shipped yesterday. I will amend the babel transform to conditionally insert the
shouldComponentUpdate. Thanks for letting me know! v18.2.0 should be fine.