React-dates: Daylight saving time in Brazil and duplicated October 15

Created on 16 Oct 2017  路  4Comments  路  Source: airbnb/react-dates

Hey,

Selecting October 15 or 16 in America/Sao_Paulo timezone gives me duplicated days:

peek 2017-10-16 14-35

This is a new issue originally reported by @felquis in #55.

bug
Source
picture derekstavis
👍2

Most helpful comment

Oh jokes it's only when selected. That's really weird!

picture majapw on 16 Oct 2017
👍2

All 4 comments

Alright, at airbnb.com you cannot reproduce it because day 15 is out of range.

felquis picture felquis on 16 Oct 2017

But are two October 16s visible?

majapw picture majapw on 16 Oct 2017

Oh jokes it's only when selected. That's really weird!

majapw picture majapw on 16 Oct 2017
👍2

The real problem is with endOf function of moment. At Oct 15th, the endOf was pointing to GMT 2:59:59. At Oct 16th, the start was GMT 2:00:00. So there was an hour that, according to moment, belongs to two days, when it should belong only to Oct 16th. Fixed it making the endOf of Oct 15th be one millisecond before the start of Oct 16th.

https://github.com/pagarme/pilot/commit/78afd202d4de593e62376ba4aef0f5992fa735b8

darakeon picture darakeon on 18 Oct 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

swaritkohli picture swaritkohli  路  3Comments
sag1v picture sag1v  路  3Comments
Daniel15 picture Daniel15  路  3Comments
maciej-w picture maciej-w  路  3Comments
yokomizor picture yokomizor  路  3Comments