React-dates: Keyboard Accessibility help modal broken when only 1 month is visible

[emmenko]

Version: [email protected]

[emmenko]

Also, is there a way to not show the ? button?

[ConAntonakos]

I noticed this as well.

Should we add overflow: auto to the .DayPickerKeyboardShortcuts__panel class? Or maybe don't set bottom: 0?

I found the culprit to be a line-height style issue. It was set at a fixed px number.

[ConAntonakos]

Also, there seems to be some clipping for .DayPickerKeyboardShortcuts__show--bottom-right?

Ostensibly from this rule: border-top: 26px solid #fff. Maybe make it transparent instead?

I can create a separate issue for this if you want or create a PR.

[majapw]

Huzzah! Totally not surprised that these things broke (it was a very big PR) and very happy to accept PRs to fix them.

Quick stop-gap to hide the ? would be just to hide it in CSS (I think it's .DayPickerKeyboardShortcuts__show?), but yeah we should probs fix the panel. :)

[atkinchris]

We hastily patched this with .DayPickerKeyboardShortcuts__panel { position: fixed; }. Not perfect, but functional.

[dburles]

Can see the behaviour here: http://airbnb.io/react-dates/?selectedKind=DayPicker&selectedStory=single%20month&full=0&down=1&left=1&panelRight=0&downPanel=kadirahq%2Fstorybook-addon-actions%2Factions-panel

[majapw]

Ping! Sorry for the delay, but here's a PR - https://github.com/airbnb/react-dates/pull/477

[emmenko]

Cool, thanks for addressing this 👍