React-dates: Missing dependency `react-addons-shallow-compare`

[ryexley]

Tried pulling this into a project today and I'm getting a build error:

Error: Cannot resolve module 'react-addons-shallow-compare'

Looks like that dependency is used in several of the components, but it's listed as one of the devDependencies in package.json...seems like that needs to be moved to one of the dependencies so it can be installed for use in production. Am I missing something?

[ljharb]

Since react things are singletons, it'd need to be a peer dependency + dev dependency. Thanks for the report!

[ljharb]

Ah, actually it's already a peerDependency - run npm ls and you'll see all the missing peer dependencies that this project requires.

[ljharb]

I've updated the readme with an installation command that will grab all the peer deps for you.

[coreylight]

Is there a way to use the traditional npm install process instead of the custom command? It doesn't seem to line up with other packages out there that just rely on npm install/postinstall etc. I don't have a specific alternative (sorry) but the current process doesn't exactly work 100% with yarn. Thanks for the lib.

[jpollard-cs]

@coreylight yarn already has this covered for you 😄 https://yarnpkg.com/en/docs/cli/add#toc-yarn-add-peer-p

[coreylight]

So I did this:

⚡ yarn add react-dates
yarn add v0.15.1
warning [email protected]: Dependency "events" listed in "dependencies" is the name of a built-in module
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning Unmet peer dependency "react-addons-shallow-compare@>=0.14".
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 8 new dependencies.
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
│  └─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
✨  Done in 10.33s.

Then when I fired up my webpack build again I got this:

ERROR in ./~/react-dates/lib/components/DayPicker.js
Module not found: Error: Cannot resolve module 'react-addons-shallow-compare' in /Users/corey/Documents/hud/node_modules/react-dates/lib/components
 @ ./~/react-dates/lib/components/DayPicker.js 698:18-57

ERROR in ./~/react-dates/lib/components/CalendarMonthGrid.js
Module not found: Error: Cannot resolve module 'react-addons-shallow-compare' in /Users/corey/Documents/hud/node_modules/react-dates/lib/components
 @ ./~/react-dates/lib/components/CalendarMonthGrid.js 372:18-57

ERROR in ./~/react-dates/lib/components/CalendarDay.js
Module not found: Error: Cannot resolve module 'react-addons-shallow-compare' in /Users/corey/Documents/hud/node_modules/react-dates/lib/components
 @ ./~/react-dates/lib/components/CalendarDay.js 354:18-57
Child html-webpack-plugin for "index.html":

Am I missing something?

[jpollard-cs]

try yarn add react-dates -P

[coreylight]

Seems to cause the same issue.

Removed react-addons-shallow-compare and also react-dates
Then ran this:

⚡ yarn add react-dates -P
yarn add v0.15.1
warning [email protected]: Dependency "events" listed in "dependencies" is the name of a built-in module
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning Unmet peer dependency "react-addons-shallow-compare@>=0.14".
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 8 new dependencies.
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
✨  Done in 8.59s.

So, same thing?

[ljharb]

For the record, if something works with npm but not with yarn, it's a yarn bug - please file it on their repo.

@coreylight the reason for the fancy install command is because npm doesn't offer an easy way to guarantee you have the right peer deps in your package.json. yarn add -P may indeed offer that, but the command provided should work just fine with npm, after which you can regenerate your yarn.lock file.

[coreylight]

It seems as if you just duplicate all the peerdeps into the dependencies in the package.json, it will work great for npm 3+ users. npm 2 users can just run npm dedupe if they want?

[ljharb]

npm 2 automatically installs peer deps, but doesn't put them in package.json - which is an error. Peer deps of deps should always be explicitly listed in package.json, which this command achieves in npm 2 and 3+.

[jpollard-cs]

@coreylight yeah not working for me either - maybe I misread the docs. I would just follow @ljharb's suggestion for now (install via NPM). Also if you're on a PC I put together a PowerShell command (to help with the peer dependencies install) that's in the comments of this PR here: https://github.com/airbnb/react-dates/pull/107