react-data-grid-addons breaking on oneOfType using toolbar and data with React 16

Created on 31 Oct 2017  ·  6Comments  ·  Source: adazzle/react-data-grid

  • Have you already searched for similar issues? Please help us out and double-check first!

  • Also, please don't be that person who deletes this template. It's here for a reason.

  • Thanks!


Which version of React JS are you using?

✅ Officially supported ✅

  • [ ] v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • [ ] v15.5.x
  • [ ] v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • [ ] v16.x.x

Which browser are you using?

✅ Officially supported ✅

  • [ ] IE 9 / IE 10 / IE 11
  • [ ] Edge
  • [ ] Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • [ ] Firefox
  • [ ] Safari

I'm submitting a ...

  • [x ] 🐛 Bug Report
  • [ ] 💡 Feature Request

👋 Need general support? Not sure about how to use React itself, or how to get started with the Grid?
Please do not submit support request here. Instead see

https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md


Issue Details

Please include:

  • What the current behavior is
When trying to use a filterable table with React 16 the page won't load. The following error is reported in the console: 

Uncaught TypeError: Cannot read property 'oneOfType' of undefined
    at Object.defineProperty.value (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:30538)
    at __webpack_require__ (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:30)
    at Object.defineProperty.value (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:29772)
    at __webpack_require__ (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:30)
    at Object.defineProperty.value (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:26914)
    at __webpack_require__ (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:30)
    at Object.defineProperty.value (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:26861)
at __webpack_require__ (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:30)
    at Object.defineProperty.value (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:14313)
    at __webpack_require__ (webpack-internal:///./node_modules/react-data-grid-addons/dist/react-data-grid-addons.js:30)

The above references the following code in the 'react-data-grid-addons' file:

      var Portal = _react2.default.createClass({
           displayName: 'Portal',
                propTypes: {
    /**
     * A Node, Component instance, or function that returns either. The `container` will have the Portal children
     * appended to it.
     */
    container: _react2.default.PropTypes.oneOfType([_componentOrElement2.default, _react2.default.PropTypes.func])
  },
  • What the desired behvaior is
  • (If Bug) Steps to reproduce the issue
  • (If Feature) The motivation / use case for the feature

Most helpful comment

@tonytangau we are actively working v4 and it should fully support React 16. There is no set timeline at the moment but we are targeting next month. In the meantime you can use react-data-grid@next if you need immediate React 16 support but this is still work in progress.

All 6 comments

Hi @cimigree, React 16 is not officially supported. Please take a look at this comment for a possible workaround.

@amanmahajan7 Any updates? Or anything we can help to fix these? Given many people are using React 16 now, maybe it's time for us to support it.

@tonytangau we are actively working v4 and it should fully support React 16. There is no set timeline at the moment but we are targeting next month. In the meantime you can use react-data-grid@next if you need immediate React 16 support but this is still work in progress.

@amanmahajan7 great news! Thanks for the update.

@amanmahajan7
Will the following functionalities work with this version - _react-data-grid@next_

  • Column reordering
  • Group by column
  • Sorting

My app is using other plugins that dependent on React16, hence I can't downgrade the react version where RDG works. so, eagerly waiting for the react-data-grid to support v16.

@amanmahajan7
Hello, Is there any update on the issue "react-data-grid-addons breaking on oneOfType using toolbar and data with React 16" for react-data-grid-addons

Thanks, Reetika

Was this page helpful?
0 / 5 - 0 ratings

Related issues

KalKhera picture KalKhera  ·  3Comments

localhosted picture localhosted  ·  4Comments

anil1712 picture anil1712  ·  4Comments

oliverwatkins picture oliverwatkins  ·  4Comments

markmus picture markmus  ·  4Comments