React-beautiful-dnd: Please remove noisy console message in development.

Created on 11 Mar 2019  路  6Comments  路  Source: atlassian/react-beautiful-dnd

Hi,

Thanks for building this, I'm really liking it so far except for one thing:

Screen Shot 2019-03-10 at 9 53 32 PM

It's not appropriate to pollute everyones console with noisy messages like this. According to my count (find . -name 'package.json' | wc -l), I have 1,855 dependencies in my project and out of all of these dependencies, only ONE is polluting my console with messages by default: react-beautiful-dnd.

I shouldn't have to enable production builds in my webpack configuration just to make one dependency not emit a noisy marketing banner 馃槂 .

Thank you,

Michael

Most helpful comment

Looks like the next version of React will include a native way of reporting these things so they look consistent (the crux of this issue).

https://github.com/facebook/react/pull/15170

cc/ @alexreardon

All 6 comments

Also, it is not a marketing banner. Nested scroll containers is not supported and can lead to bugs 馃憤

I linked to the issue in the message to show that we plan on overcoming the limitation

Perhaps we could add a link to the disable warnings guide in the messages? Thoughts @iMerica ?

Maybe the warnings could look a little less banner-y and more warning-y

For example, in React:

console2

Proposed changes

  • Remove the "react-beautiful-dnd" green text so this warning looks less like an advertisement and more like a warning.
  • Remove "This is a development only message."
  • Example:
    Screen Shot 2019-03-11 at 1 08 38 AM

Looks like the next version of React will include a native way of reporting these things so they look consistent (the crux of this issue).

https://github.com/facebook/react/pull/15170

cc/ @alexreardon

Was this page helpful?
0 / 5 - 0 ratings