React-admin: RejectButton is coded as AcceptButton

Created on 30 Apr 2019  路  3Comments  路  Source: marmelab/react-admin

What you were expecting:
I would expect the code in RejectButton.js to define a class called RejectButton.

What happened instead:
Take a look at RejectButton.js and you'll notice the code defines a class named AcceptButton. Seems a little confusing, because there is actual code for rejection and it's using the thumbs down icon.

Steps to reproduce:
Code inspection of RejectButton.js

Related code:
N/A

Other information:
n/a

Environment

  • React-admin version: master
  • Last version that did not exhibit the issue (if applicable): n/a
  • React version: n/a
  • Browser: n/a
  • Stack trace (in case of a JS error): n/a
bug

Most helpful comment

This issue should be closed, since a PR fixed it

All 3 comments

Thanks for reporting. It looks like a bad copy/paste. Would you mind opening a PR to fix it ?

Sure, will do

This issue should be closed, since a PR fixed it

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pixelscripter picture pixelscripter  路  3Comments

Dragomir-Ivanov picture Dragomir-Ivanov  路  3Comments

ilaif picture ilaif  路  3Comments

samanmohamadi picture samanmohamadi  路  3Comments

kdabir picture kdabir  路  3Comments