Rawtherapee: locallab keyboard shortcuts issue

[heckflosse]

Using shortcuts (e.g. z to zoom in) does not work because of this (whatever that is):

[sguyader]

@heckflosse I don't have this problem (fresh build, commit 2394e06)

[heckflosse]

@sguyader I have the issue only when the locallab settings tool is opened.

[sguyader]

@heckflosse yes tried also with the locallab settings open, but no issue here. However I use the Toowagrey theme, it's the only difference I see (besides the photograph of course).

[heckflosse]

@sguyader I just checked again. With all themes I get the bug when the focus is on a spot in settings. I guess it's some automatism to select the spot by typing its name, but I dont get how it works (it doesn't seem to work)

[Beep6581]

I get the popup too. Looks like a standard GtkTreeView search box, though it doesn't match anything I type.

[Beep6581]

diff --git a/rtgui/controlspotpanel.cc b/rtgui/controlspotpanel.cc
index 0fecf9b54..37d93d4bd 100644
--- a/rtgui/controlspotpanel.cc
+++ b/rtgui/controlspotpanel.cc
@@ -98,6 +98,7 @@ ControlSpotPanel::ControlSpotPanel():
     buttonvisibilityconn_ = button_visibility_.signal_clicked().connect(
                                 sigc::mem_fun(*this, &ControlSpotPanel::on_button_visibility));

+    treeview_.set_enable_search(false); // Disable search to prevent hijacking keyboard shortcuts #5265
     treeview_.set_grid_lines(Gtk::TREE_VIEW_GRID_LINES_VERTICAL);

     scrolledwindow_.add(treeview_);

[sguyader]

@sguyader I just checked again. With all themes I get the bug when the focus is on a spot in settings. I guess it's some automatism to select the spot by typing its name, but I dont get how it works (it doesn't seem to work)

Ok, when a spot is focused in the list I get the same behaviour indeed.

[Pandagrapher]

@Beep6581
In fact, this patch doesn't completely deactivate treeview search. Pressing Ctrl+F the search popup reappears if treeview is focused, otherwise a Gtk-critical error is raised. I have introduced your patch then corrected the side effects with commit 853a6f0

Pierre

[Pandagrapher]

@heckflosse @Beep6581
Is it ok to close this issue?
Pierre

[heckflosse]

Ok from me. @Beep6581 ?

[Beep6581]

Fix confirmed.