Radarr: .srt file(s) in subfolders are not being imported.

[douglas24]

RARBG movie convention puts subtitle files in a folder called 'Subs' within the movie folder. Radarr only seems to see subtitle files for import in the main movie folder, not subfolders, so the RARBG subtitle files are ignored and not imported.

[hotio]

You certain radarr copies them over at all? IIRC radarr does nothing to subtitles.

[galli-leo]

Duplicate of #121

[danielbibit]

Please, re-open this issue as it's NOT a duplicate of #121. I'm using version 0.2.0.1067, and #2506 don't resolve this issue. Subtitles on /downloads/movieTitle/Subs aren't being properly imported.

[mstrdraco]

I've noticed this same issues, IE a Movie just downloaded today and it has a folder called "Subtitles" where the .srt files reside, when Radarr imported the movie it downloaded the main movie but ignored the Subtitles folder and therefore didn't import the .srt files.

[Qstick]

Looks like this is due to the ExtraService only scanning the top level when importing files for new downloads.

https://github.com/Radarr/Radarr/blob/bd969e0bc351a267694d532930b14ef3dc13264a/src/NzbDrone.Core/Extras/ExtraService.cs#L69

This behavior was brought over from Sonarr, since we are only downloading a single movie at a time and there is no risk of confusing which extra files go with what movie, I don't see the harm in changing this. @galli-leo ?

[galli-leo]

@Qstick Sounds good to me

[Qstick]

How are subs typically named when they are in sub directories? currently we only import if name matches movie name, so we will have to add some logic to parse other sub names.

Are they just language codes like en.srt or are they named different?

[MikeLund]

@Qstick They can be named quite differently, and then you have some other fun stuff if you're considering HI/non-HI subs.

So instead, I'd suggest just taking all files with subtitle extension, and importing them with their original names. Then you leave the rest of the heavy-lifting to the media player instead of building some AI; more subtitle options for the media player is less harmful than losing files because they weren't named properly :)

[douglas24]

@Qstick original file names makes the most sense because there couldn't have been name conflicts with them in the same upload directory, and there are usually at least two types of English subtitles (one for only when the characters don't speak English, and a second for the entire dialogue).

[thevik]

this is still an issue for me, is there any updated news on this?

[n1nj4888]

This seems to still be an issue - Any updates on when / if this is planned to be fixed?

[jpogs]

Fixed this for my personal use but also submitted a pull request to share to the community

3647

[n1nj4888]

Thanks for looking into this @jpogs ! It would be great if this could get fixed!

@Qstick - What needs to happen to get this merged into the develop / stable branch?

Thanks!

[jpogs]

Happy to help @n1nj4888 ! I know how tedious having to import subs for every movie so I hope this helps!

[douglas24]

Super glad to see this is finally coming!

[douglas24]

@jpogs is there a way I can include this in my radarr install or do I need to wait for the next release for the developer channel that I'm on?

[jpogs]

@douglas24 I recommend waiting for the next developer release when this I think will get integrated. If you are interested to test this build I created a release under my fork.

https://github.com/jpogs/Radarr/releases/tag/pre-release

[douglas24]

@douglas24 I recommend waiting for the next developer release when this I think will get integrated. If you are interested to test this build I created a release under my fork.

https://github.com/jpogs/Radarr/releases/tag/pre-release

Thanks I will check it out since the new develop release for June didn't include the subtitle fix.

[Xebozone]

Can we re-open this one? Apparently the change that fixes it was reverted in Dec? ( #4207 )

[Xebozone]

@Qstick ?

[bpersino]

I just tested this out and I can confirm that when downloading a RARBG movie, the subtitle file in folder called 'Subs', subtitle files are ignored and are not imported/copied/moved.
Package Version = 3.0.0.2871-ls5 by linuxserver.io

[jpogs]

@Xebozone, @bpersino, this fix was reverted as the update only worked exclusively for RARBG subs. The corrected fix is now pending for review, please be patient while @Qstick reviews #4340

[Xebozone]

@Xebozone, @bpersino, this fix was reverted as the update only worked exclusively for RARBG subs. The corrected fix is now pending for review, please be patient while @Qstick reviews #4340

Hey @jpogs ,
Thanks for the update! I appreciate all the hard work you guys do.
Looking forwards to the update!

[douglas24]

Was this change reverted again? I just noticed the current radarr version (0.2.0.1504 on Windows) is ignoring subtitle files (srt) in subfolders again.

[ta264]

Yes, the fix caused more problems than it solved

[douglas24]

Yes, the fix caused more problems than it solved

Is there a way to include 'folder' in the extensions of files to import so radarr can just import subfolders as is with whatever is in them?

[nebuchar]

Please, reopen the issue, as the problem is still happening

[austinwbest]

If it was causing problems, it is unlikely to be added back anytime soon since there are other pressing things.

Work around: use a custom script for import trigger to grab contents of subfolders and copy it over + name it accordingly.

[nebuchar]

Does custom scripts run after the movie has been imported/renamed, and before cleaning the leftovers?

[douglas24]

Can you please re-open this?

I upgraded to v3 and this functionality seems to be missing. It needs the ability to check all subfolders for files that match extensions defined by user in the 'Import Extra Files' section.

[douglas24]

If it was causing problems, it is unlikely to be added back anytime soon since there are other pressing things.

Work around: use a custom script for import trigger to grab contents of subfolders and copy it over + name it accordingly.

Any chance you could share an example script?