Qtox: 1.7.0 doesn't show the user went offline, only online

[yurivict]

Previous versions did show "offline" records, and it makes sense, so this is a regression:

[AliceGrey]

I'll take a look at this. Most likely happened with merge #3983 or maybe sometime earlier? Any ideas @Diadlo

[zetok]

@AliceGrey generally when in doubt, git bisect :-)

3983 was merged after v1.7.0 was released, so that's not it.

https://github.com/qTox/qTox/wiki/Testing#regression-testing ← a bit on using bisect

f5011cdb2feb2da042e373b4e4094e967bde8120 is the last commit that works with the 0.0.0 irungentoo toxcore, and most likely already has the regression included.

Working version for @yurivict is most likely v1.5.2, perhaps even v1.6.0.

git bisect start
git bisect good v1.5.2
git bisect bad f5011cdb2feb2da042e373b4e4094e967bde8120

Note that testing most likely should be done on a separate profile, since the kind of version switching that bisect does would result in an ~erased history, settings, etc.

[AliceGrey]

Thank you @zetok. I'll take a look at that

[shinodem]

i just update to 1.7 and can't see friends in online at old versions of qtox

[yurivict]

In 1.7.1 friends are online ok for me.

[shinodem]

@yurivict Where i can find that build? Thanks in advance

[yurivict]

This depends on your system.

[zetok]

@AliceGrey any update?

[shinodem]

@yurivict win10 x64

[yurivict]

1.7.0 is supposed to be the same as 1.7.1 though. It might be a Windows problem.
I don't use Windows.

[shinodem]

it seams what 1.7.0 need much time sometimes 10 minutes sometimes 1 hour to connect to friends to see them in online.

[yurivict]

@shinodem You need to create a separate bug for this. This must be the windows problem, because I don't see this.

[zetok]

This must be the windows problem, because I don't see this.

Not a windows problem, but a separate issue should be created.

[Diadlo]

Should be fixed in current master. Can anyone confirm?
But in current master there is status message duplication (will be fixed in #4066)

[yurivict]

Still the same problem with 3b56a6e

[Diadlo]

I can't reproduce

[yurivict]

It prints "online" message many times in a row. They should be strictly alternating.

[Diadlo]

@yurivict Friend just goes offline -> online -> offline -> online?

[yurivict]

yes, same kind of message several times in a row,

[eagle500]

It happens to me also.

[zetok]

Still not fixed on 5a043599017472c16aa08265edfed9123c94

NB: if someone's status isn't Online, messages differ: