Qtox: Update noptification icon properly

Created on 8 Oct 2016  路  12Comments  路  Source: qTox/qTox

Stupid Github doesn't let me upload an image file.
http://expirebox.com/download/277c38163de6bc3e92ed601611df48f6.html

C-bug M-ui

Most helpful comment

@zetok After A LOT of digging and debugging I found the culprate. I'll submit a PR :+1:

All 12 comments

image from link:
1922d177de47318d55087e8fc853affa

@zetok @GitHubHatesTor I am unable to reproduce this issue. I told qtox to connect to a proxy that was down and this is what rendered.
Edit: The icon still displays properly with ipv6 enabled. I just usually leave it off and double checked with it on.
notification bar

@AliceGrey Right.

Steps:

  1. Connect to working proxy
  2. Take proxy down
  3. spectacle ea7954

@zetok Should this be closed since it's not reproducible and the creator hasn't responded?

@AliceGrey err? It's reproducible, I've posted the steps.

@zetok You said > Right. I thought you meant you weren't able to reproduce it.

Sorry, I should have been more verbose. What I meant was "Oh, so it's not obvious what the steps are. Right. Here are the steps"

@zetok No worries, I'll see what I can do to get this one fixed.

@zetok I've done some poking around in my free time and it looks like after being disconnected from the proxy and DHT updateIcons() never gets called. It does get called when it connects though.

@zetok From what I've read in the code, updateIcons() gets called by onStatusSet() which is connected to Core::statusSet.

Where I get lost is when DHT gets disconnected when you take down the proxy, emit disconnected(); gets called which then calls onDisconnected which does emit statusSet(Status::Offline); which should trigger onStatusSet() and call updateIcons() but for some reason it never gets to updateIcons()

@zetok After A LOT of digging and debugging I found the culprate. I'll submit a PR :+1:

@AliceGrey

but for some reason it never gets to

Becouse Offline status here leads to the default case and return without emit statusSet(status);

Was this page helpful?
0 / 5 - 0 ratings