Qownnotes: spell check: etc. comes up as a spelling mistake

[sbrl]

I've found another teething issue in the spell checker. This ones really minor, but it would appear that QOwnNotes' spell checking implementation has fallen for the classic etc. trick. I've seen this in several spell checking-supporting programs, but basically it tries to correct etc. to etc.., not realising that a dot is in fact already present after the word.

Expected behaviour

The following should not be classed as a spelling error:

etc.

Actual behaviour

It is classed as a spelling error:

Steps to reproduce

1. Make sure spell checking is enabled (I'm using en_GB)
2. Type etc.
3. Note that it is classed as a spelling error
4. See that etc. is in the spelling corrections
5. Select etc. as the spelling correction
6. Observe that it now says etc.., and it's still marked as a spelling error
7. Go to step 3

Output from the debug section in the settings dialog

Debug output

QOwnNotes Debug Information

General Info

Current Date: Mon Nov 11 14:36:18 2019
Version: 19.11.5
Build date: Nov 5 2019
Build number: 610
Platform: linux
Operating System: Ubuntu 18.04.3 LTS
Build architecture: x86_64
Current architecture: x86_64
Release: Launchpad PPA
Qt Version (build): 5.9.5
Qt Version (runtime): 5.9.5
Portable mode: no
Settings path / key: /home/bryan-smithl/.config/PBE/QOwnNotes.conf
Application database path: /home/bryan-smithl/.local/share/PBE/QOwnNotes/QOwnNotes.sqlite
Application arguments: QOwnNotes
Qt Debug: 0
Locale (system): en_GB
Locale (interface): empty
Icon theme: breeze-dark-qownnotes
Notes in current note folder: 64
Calendar items: 24
Enabled scripts: 3

Server Info

serverUrl: https://nextcloud.starbeamrainbowlabs.com
appIsValid: no
notesPathExists: empty
connectionErrorMessage: empty

Note folders

currentNoteFolderId: 1

Note folder default

id: 1
isCurrent: yes
activeTagId: -1
localPath: /home/bryan-smithl/Documents/Nextcloud/Notes
remotePath: Notes
cloudConnectionId: 1
isShowSubfolders: yes
isUseGit: no
activeNoteSubFolder name: Paper Summaries
database file: /home/bryan-smithl/Documents/Nextcloud/Notes/notes.sqlite

Cloud connections

Cloud connection Default

id: 1
isCurrent: yes
serverUrl: https://nextcloud.starbeamrainbowlabs.com
username: admin

Enabled scripts

Script Paste Latex Image

id: 1
path: /home/bryan-smithl/.local/share/PBE/QOwnNotes/scripts/paste-latex-image/paste-latex-image.qml
variablesJson: empty
identifier: paste-latex-image
version: 0.0.1
minAppVersion: 17.05.6

Script Paste HTML as GitHub Markdown

id: 2
path: /home/bryan-smithl/.local/share/PBE/QOwnNotes/scripts/paste-html-as-github-markdown/paste-html-as-github-markdown.qml
variablesJson: empty
identifier: paste-html-as-github-markdown
version: 0.0.1
minAppVersion: 17.08.2

Script Support for PlantUML in notes

id: 3
path: /home/bryan-smithl/.local/share/PBE/QOwnNotes/scripts/render-plantuml/render-plantuml.qml
variablesJson:

{
    "javaExePath": "java",
    "noStartUml": true,
    "plantumlJarPath": "/usr/share/plantuml/plantuml.jar",
    "workDir": "/tmp"
}

identifier: render-plantuml
version: 0.0.6
minAppVersion: 17.05.7

Settings

ActiveNoteHistoryItem (NoteHistoryItem): <binary data>
Debug/fakeOldVersionNumber (QString): false
Debug/fileLogging (QString): false
Editor/CurrentSchemaKey (QString): EditorColorSchema-cdbf28fc-1ddc-4d13-bb21-6a4043316a2f
Editor/autoBracketClosing (QString): true
Editor/autoBracketRemoval (QString): true
Editor/disableCursorBlinking (QString): false
Editor/editorWidthInDFMOnly (QString): true
Editor/highlightCurrentLine (QString): true
Editor/vimMode (QString): false
IssueAssistantDialog/geometry (QByteArray): <binary data>
LastUpdateCheck (QDateTime): 2019-11-11T14:13:56
MainWindow/geometry (QByteArray): <binary data>
MainWindow/mainToolBar.iconSize (QString): 24
MainWindow/menuBarGeometry (QByteArray): <binary data>
MainWindow/noteSubFolderTreeWidgetExpandState-1 (QStringList): PhD
MainWindow/noteTextEdit.code.font (QString): Ubuntu Mono,15,-1,5,50,0,0,0,0,0
MainWindow/noteTextEdit.font (QString): Ubuntu,15,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.code.font (QString): monospace,12,-1,2,50,0,0,0,0,0
MainWindow/noteTextView.font (QString): Ubuntu,12,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.ignoreCodeFontSize (QString): true
MainWindow/noteTextView.rtl (QString): false
MainWindow/noteTextView.underline (QString): true
MainWindow/showNotesFromAllNoteSubFolders (bool): false
MessageBoxOverride/move-notes (QString): 16384
NoteHistory-1 (QVariantList): <variant list with 50 item(s)>
NoteHistoryCurrentIndex-1 (QString): 49
PiwikClientId (QString): <hidden>
ScriptRepositoryDialog/geometry (QByteArray): <binary data>
ScriptRepositoryDialog/mainSplitterState (QByteArray): <binary data>
SearchEngineId (QString): 2
SettingsDialog/geometry (QByteArray): <binary data>
SettingsDialog/mainSplitterState (QByteArray): <binary data>
Shortcuts/MainWindow-action_Print_note_markdown (QString): Ctrl+Alt+Shift+P
Shortcuts/MainWindow-togglePanel-notePreviewDockWidget (QString): Ctrl+Shift+P
ShowSystemTray (QString): false
StartHidden (QString): false
TagAddDialog/geometry (QByteArray): <binary data>
TodoDialog/geometry (QByteArray): <binary data>
TodoDialog/mainSplitterState (QByteArray): <binary data>
TodoDialog/showCompletedItems (QString): 0
TodoDialog/todoListSelectorSelectedItem (QString): Personal
WelcomeDialog/geometry (QByteArray): <binary data>
acceptAllExternalModifications (QString): false
allowDifferentNoteFileName (QString): false
allowNoteEditing (bool): true
allowOnlyOneAppInstance (QString): true
appMetrics/disableAppHeartbeat (QString): false
appMetrics/disableTracking (QString): false
appMetrics/notificationShown (QString): true
automaticNoteFolderDatabaseClosing (QString): false
checkSpelling (bool): true
closeTodoListAfterSave (QString): false
cryptoKey (QString): <hidden>
currentNoteFolderId (QString): 1
currentWorkspace (QString): initial
cursorWidth (QString): 2
customNoteFileExtensionList: empty
darkMode (QString): true
darkModeColors (QString): true
darkModeIconTheme (QString): true
darkModeTrayIcon (QString): true
defaultNoteFileExtension (QString): md
demoNotesCreated (QString): true
disableAutomaticUpdateDialog (QString): true
disableSavedSearchesAutoCompletion (QString): false
dockWasInitializedOnce (QString): true
enableSocketServer (QString): true
externalEditorPath (QString): empty
fullyHighlightedBlockquotes (QString): false
gitCommitInterval (QString): 30
gitExecutablePath (QString): empty
gitLogCommand (QString): empty
guiFirstRunInit (bool): true
ignoreAllExternalModifications (QString): false
ignoreAllExternalNoteFolderChanges (QString): false
ignoreNoteSubFolders (QString): ^\.
imageScaleDown (QString): false
imageScaleDownMaximumHeight (QString): 1024
imageScaleDownMaximumWidth (QString): 1024
initialLayoutIdentifier (QString): minimal
insertTimeFormat (QString): yyyy-MM-dd hh:mm
interfaceFontSize (QString): 11
interfaceLanguage (QString): empty
internalIconTheme (QString): false
itemHeight (QString): 22
legacyLinking (QString): false
localTrash/autoCleanupDays (QString): 30
localTrash/autoCleanupEnabled (QString): true
localTrash/supportEnabled (QString): true
markdownHighlightingEnabled (QString): true
navigationPanelHideSearch (QString): false
networking/ignoreSSLErrors (QString): true
networking/proxyType (QString): 2
newNoteAskHeadline (QString): false
noteEditIsCentralWidget (QString): true
noteListPreview (QString): false
noteSaveIntervalTime (QString): 10
noteSubfoldersPanelDisplayAsFullTree (QString): true
noteSubfoldersPanelHideSearch (QString): false
noteSubfoldersPanelOrder (QString): 0
noteSubfoldersPanelShowFullPath (QString): false
noteSubfoldersPanelShowNotesRecursively (QString): true
noteSubfoldersPanelShowRootFolderName (QString): true
noteSubfoldersPanelSort (QString): 0
notesPanelOrder (QString): 0
notesPanelSort (QString): 1
notesPath (QString): /home/bryan-smithl/Documents/Nextcloud/Notes
notifyAllExternalModifications (QString): false
overrideInterfaceFontSize (QString): false
ownCloud/supportEnabled (QString): true
ownCloud/todoCalendarBackend (QString): 3
ownCloud/todoCalendarCalDAVPassword (QString): <hidden>
ownCloud/todoCalendarCalDAVServerUrl (QString): empty
ownCloud/todoCalendarCalDAVUsername (QString): empty
ownCloud/todoCalendarCloudConnectionId (QString): 1
ownCloud/todoCalendarDisplayNameList: empty
ownCloud/todoCalendarEnabledList: empty
ownCloud/todoCalendarEnabledUrlList: empty
ownCloud/todoCalendarUrlList: empty
ownCloudInfo/appIsValid (bool): false
ownCloudInfo/connectionErrorMessage (QString): empty
ownCloudInfo/notesPathExistsText (QString): empty
ownCloudInfo/serverVersion (QString): empty
recentNoteFolders (QString): /home/bryan-smithl/Documents/Notes
restoreCursorPosition (QString): true
savedSearches/noteFolder-1 (QStringList): Note 2019-11-11T14.19.09, Meeting with Chandra - 8th November 2019 2019-11-08T11.04.29, tidal, Note 2019-10-28T14.15.42, Note 2019-10-22T18.02.02, Note 2019-10-22T17.51.12, Note 2019-10-22T12.34.44, Note 2019-10-02T13.54.59, Note 2019-10-02T13.40.40
showMatches (QString): true
showMenuBar (bool): true
showStatusBar (bool): true
spellCheckLanguage (QString): en_GB
systemIconTheme (QString): false
tagWasAddedToNote (QString): true
taggingShowNotesRecursively (QString): true
tagsPanelHideSearch (QString): false
tagsPanelOrder (QString): 0
tagsPanelSort (QString): 0
toolbar/1/items (QStringList): action_New_note, action_Find_note, action_Remove_note, action_Open_note_in_external_editor, actionShow_local_trash, actionAllow_note_editing, , action_Back_in_note_history, action_Forward_in_note_history, , action_Find_text_in_note, actionReplace_in_current_note, , actionShow_versions, actionShow_trash, actionShare_note, , actionOpen_List
toolbar/1/name (QString): mainToolBar
toolbar/1/title (QString): main toolbar
toolbar/2/items (QStringList): actionFormat_text_bold, actionFormat_text_italic, actionStrike_out_text, actionInsert_code_block, actionInsert_block_quote
toolbar/2/name (QString): formattingToolbar
toolbar/2/title (QString): formatting toolbar
toolbar/3/items (QStringList): actionInsert_Link_to_note, actionInsert_image, actionInsert_current_time
toolbar/3/name (QString): insertingToolbar
toolbar/3/title (QString): inserting toolbar
toolbar/4/items (QStringList): action_Encrypt_note, actionEdit_encrypted_note, actionDecrypt_note
toolbar/4/name (QString): encryptionToolbar
toolbar/4/title (QString): encryption toolbar
toolbar/5/items (QStringList): actionWorkspaceComboBox, actionStore_as_new_workspace, actionRemove_current_workspace, actionRename_current_workspace, actionSwitch_to_previous_workspace, actionUnlock_panels, , actionToggle_distraction_free_mode, action_Increase_note_text_size, action_Decrease_note_text_size, action_Reset_note_text_size
toolbar/5/name (QString): windowToolbar
toolbar/5/title (QString): window toolbar
toolbar/6/items (QString): action_Quit
toolbar/6/name (QString): quitToolbar
toolbar/6/title (QString): quit toolbar
toolbar/size (QString): 6
useUNIXNewline (QString): false
webSocketServerService/bookmarksNoteName (QString): Bookmarks
webSocketServerService/bookmarksTag (QString): bookmarks
webSocketServerService/port (QString): 22222
workspace-initial/name (QString): Minimal
workspace-initial/noteSubFolderDockWidgetVisible (QString): true
workspace-initial/windowState (QByteArray): <binary data>
workspaces (QString): initial

System environment

ACKRC: /home/bryan-smithl/bin/settings/.ackrc
CARGO_HOME: /home/bryan-smithl/.config/cargo
CLUTTER_IM_MODULE: xim
COMPIZ_CONFIG_PROFILE: ubuntu
DBUS_SESSION_BUS_ADDRESS: unix:path=/run/user/1001/bus
DEBEMAIL: [email protected]
DEBFULLNAME: Starbeamrainbowlabs
DEFAULTS_PATH: /usr/share/gconf/unity.default.path
DESKTOP_SESSION: unity
DISPLAY: :0
GDMSESSION: unity
GDM_LANG: en_GB
GNOME_DESKTOP_SESSION_ID: this-is-deprecated
GNOME_SESSION_XDG_SESSION_PATH: /org/freedesktop/DisplayManager/Session3
GNOME_SHELL_SESSION_MODE: ubuntu
GPG_AGENT_INFO: /run/user/1001/gnupg/S.gpg-agent:0:1
GTK2_MODULES: overlay-scrollbar
GTK_IM_MODULE: ibus
GTK_MODULES: appmenu-gtk-module:gail:atk-bridge:unity-gtk-module
HISTFILESIZE: -1
HISTSIZE: -1
HOME: /home/bryan-smithl
IM_CONFIG_PHASE: 2
LANG: en_GB.UTF-8
LANGUAGE: en_GB:en
LC_ALL: en_GB.utf8
LESS: -R
LESSCHARSET: utf-8
LESSCLOSE: /usr/bin/lesspipe %s %s
LESSOPEN: | /usr/bin/lesspipe %s
LOGNAME: bryan-smithl
LS_COLORS: rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.m4a=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.oga=00;36:*.opus=00;36:*.spx=00;36:*.xspf=00;36:
MAIL: /var/mail/bryan-smithl
MANDATORY_PATH: /usr/share/gconf/unity.mandatory.path
MICRO_TRUECOLOR: 1
OLDPWD: /etc/xrdp
PAM_KWALLET5_LOGIN: /run/user/1001/kwallet5.socket
PATH: /home/bryan-smithl/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
PULSE_SCRIPT: /etc/xrdp/pulse/default.pa
PWD: /home/bryan-smithl
QT4_IM_MODULE: xim
QT_ACCESSIBILITY: 1
QT_IM_MODULE: ibus
RUSTUP_HOME: /home/bryan-smithl/.config/rustup
SESSION_MANAGER: local/SIMVIS-CO45428A:@/tmp/.ICE-unix/24635,unix/SIMVIS-CO45428A:/tmp/.ICE-unix/24635
SHELL: /bin/bash
SHLVL: 1
SSH_AGENT_PID: 24193
SSH_AUTH_SOCK: /run/user/1001/keyring/ssh
SSH_CLIENT: 150.237.70.14 41840 22
SSH_CONNECTION: 150.237.70.14 41840 150.237.96.21 22
SSH_TTY: /dev/pts/1
TERM: xterm-256color
TEXTDOMAIN: im-config
TEXTDOMAINDIR: /usr/share/locale/
UBUNTU_MENUPROXY: 1
UID: 1001
UNITY_DEFAULT_PROFILE: unity-lowgfx
UNITY_HAS_3D_SUPPORT: false
USER: bryan-smithl
VNCDESKTOP: SIMVIS-CO45428A:1 (bryan-smithl)
XAUTHORITY: /home/bryan-smithl/.Xauthority
XDG_CONFIG_DIRS: /etc/xdg/xdg-unity:/etc/xdg/xdg-ubuntu:/etc/xdg
XDG_CURRENT_DESKTOP: ubuntu:GNOME
XDG_DATA_DIRS: /usr/share/unity:/usr/share/ubuntu:/usr/local/share:/usr/share
XDG_GREETER_DATA_DIR: /var/lib/lightdm-data/bryan-smithl
XDG_MENU_PREFIX: gnome-
XDG_RUNTIME_DIR: /run/user/1001
XDG_SEAT: seat0
XDG_SEAT_PATH: /org/freedesktop/DisplayManager/Seat0
XDG_SESSION_DESKTOP: unity
XDG_SESSION_ID: c13
XDG_SESSION_PATH: /org/freedesktop/DisplayManager/Session3
XDG_SESSION_TYPE: x11
XDG_VTNR: 7
XMODIFIERS: @im=ibus
XRDP_SESSION: 1
XRDP_SOCKET_PATH: /var/run/xrdp/sockdir
ZEITGEIST_DATA_PATH: /home/bryan-smithl/.local/share/zeitgeist
_: /usr/bin/dbus-update-activation-environment
MANAGERPID: 1458
INVOCATION_ID: b53dd39140c54ef6a4588fff17034280
JOURNAL_STREAM: 9:1155434
COMPIZ_BIN_PATH: /usr/bin/
GIO_LAUNCHED_DESKTOP_FILE: /usr/share/applications/PBE.QOwnNotes.desktop
GIO_LAUNCHED_DESKTOP_FILE_PID: 27705

[pbek]

Thank you for reporting,

@Waqar144 ? :grin:

[Waqar144]

Mmm... I am using en_US and it doesn't underline etc. for me. The Britishers are too hard when it comes to punctuation maybe :laughing:

I will try with en_GB

Edit: Reproduced with en_GB. Will fix it soon.

[Waqar144]

This is an upstream dictionary bug. It should be reported that etc. causes hunspell to mark it as misspelled.

However I will fix it in the code so that etc gets ignored

[pbek]

I don't like that "fix" at all... Hard-coded string comparisons that will hit every word for every language...

I just right-clicked the word etc and pressed Ignore. Did the same and will not affect every user.
After a restart of the application I again got the "red line" for etc, but I didn't get the spellchecker context-menu.

[pbek]

etc will also not be detected in German, as well as usw (the German abbreviation) and it has the same problem, it can be corrected to etc. and usw., I guess that is an issue of abbreviations in general.

[Waqar144]

I don't like that "fix" at all... Hard-coded string comparisons that will hit every word for every language...

I just right-clicked the word etc and pressed Ignore. ~Did the same and~ will not affect every user.
After a restart of the application I again got the "red line" for etc, but I didn't get the spellchecker context-menu.

You can also "Add to Personal"

[Waqar144]

I don't like that "fix" at all... Hard-coded string comparisons that will hit every word for every language...

On our side (in code) that's the only way.
I wasn't in favour of fixing this as well, but just did it.
Hunspell isn't perfect, and dictionaries have bug too. There are going to be many bugs like this in many other dictionaries and we can't fix them all in code.

[pbek]

It looks like it is an issue of abbreviations in general, not just "etc" and not just on British English.

[pbek]

And etc is Latin for et cetera, I even fonder why that is in the dictionaries at all.

[pbek]

Maybe we need to check every word twice, once without . and once with, but that would be a hell for spellchecking performance...

[Waqar144]

Maybe we need to check every word twice, once without . and once with, but that would be a hell for spellchecking performance...

the . is not a problem at all. You can try it with a correct word. etc. doesn't get misspelled in en_US only with en_GB. The word tokenizer takes care of the dot.

This can be fixed if we include the dot in our checking. But that'd be crazy lol
the word in the dictionary is etc. not etc.

[pbek]

etc. doesn't get misspelled in en_US

I've the same problem in ger_DE and ger_AT... And with other abbreviations too.

[Waqar144]

Yes that's cause they both have it wrong, or right.
In case of etc here are both dictionaries opened as text files:

en_GB

en_US

This is why in en_US etc is always right. Whether with a dot or without.

[pbek]

So the solution is to remove all points in all (?) the dictionaries? :grimacing:

[Waqar144]

So the solution is to remove all points in all (?) the dictionaries? grimacing

No. Because that will fix it only for the user.

The solution is to just "Add to personal" for the user.
Proper solution is for the dictionary maintainers to fix it on their side. Most(if not all) word tokenizers will tokenize the word without the dot.

[sbrl]

Ah, that explains it! Very curious that it's a bug in upstream hunspell. Does anyone know where I would report that?

I'll add it to my personal dictionary then. I just wanted to check that it wasn't a bug in the new spell-checking implementation :P

[Waqar144]

Ah, that explains it! Very curious that it's a bug in upstream hunspell. Does anyone know where I would report that?

I'll add it to my personal dictionary then. I just wanted to check that it wasn't a bug in the new spell-checking implementation :P

It's not in hunspell. It's in the dictionary
You can report it here:
https://github.com/LibreOffice/dictionaries

[pbek]

There are pull requests more than 1.5 years old, maybe we should just fork the repository into https://github.com/qownnotes/, do our own fixes and use that repository in QOwnNotes.

[pbek]

maybe we should just fork the repository into https://github.com/qownnotes/, do our own fixes and use that repository in QOwnNotes

https://github.com/qownnotes/dictionaries is up in case we want to do that...

[Waqar144]

Alright,
I have updated the dictionaries for these words:

usw

We can keep adding more as we find more problems

[pbek]

I'll add a checkbox to disable all external dictionaries to the Manage dictionaries dialog.

[Waqar144]

I'll add a checkbox to disable all external dictionaries to the _Manage dictionaries dialog_.

How about we just disable it in the code? Keep only one path for dictionaries? And that path can be managed by Dictionary Manager across all the platforms.

[pbek]

I don't see anything wrong with the current global directories. Users will (possibly) already get some dictionaries by default and if they are in the dictionary dialog they can download more and probably turn off the external dictionaries.

I guess the new checkbox will be easier for users than to remember and editing paths. :grin:

[Waqar144]

I don't see anything wrong with the current global directories. Users will (possibly) already get some dictionaries by default and if they are in the dictionary dialog they can download more and probably turn off the external dictionaries.

I guess the new checkbox will be easier for users than to remember and editing paths. grin

That's definitely true.
Windows and Mac users will probably never bother creating or using anything 'global' I am pretty sure.
Linux users might have an issue with global dictionaries not being available as everything is shared there and linux user is usually a bit more technical than the above mentioned.

So yeah, an option for everyone :+1:

[Waqar144]

@pbek
This issue is also solved now since we have created our own repo for dictionaries.

[pbek]

This issue is also solved now since we have created our own repo for dictionaries.

It will in 19.11.11 :grin:

19.11.11

• you now can disable all external dictionaries in the Manage dictionaries dialog
  
  
  
  • if activated only the downloaded dictionaries will be used
  
  
• the Manage dictionaries dialog now uses QOwnNotes dictionaries
  as source to be able to quickly fix dictionary issues or add new dictionaries
  (for #1399, thank you @Waqar144)
  
  
  
  • spellchecking for some abbreviations have been fixed
  
  
  • more dictionaries were added to the dialog
  
  

[pbek]

There now is a new release, could you please test it and report if it works for you?

[sbrl]

Sure thing, @pbek! Looks like it works perfectly :D

Note that you have to tick the "disable external dictionaries" option for it to correctly recognise etc. as not a spelling mistake though.

[pbek]

Note that you have to tick the "disable external dictionaries" option for it to correctly recognise etc. as not a spelling mistake though.

Yes, @Waqar144 had to alter the dictionaries themselves. It only works with our "custom" dictionaries.

Thank you for testing!