Pysyft: Add Torch 1.7.1

Created on 13 Dec 2020  ·  6Comments  ·  Source: OpenMined/PySyft

Description

Add Torch 1.7.1 to support matrix and tests.

Definition of Done

Torch 1.7.1 in the compatibility matrix. New Ops added to the allowlist.

Type

All 6 comments

Hey @madhavajay can you help me to get started with this issue

@devil-cyber, take a look at the merge and pr tests.yml files for GitHub Actions.
Then go see the src/syft/lib/torch/allowlist.py:

allowlist["torch.Tensor.amax"] = {
    "return_type": "torch.Tensor",
    "min_version": "1.7.0",
}

What you need to do is import torch 1.7.1 and dir(torch) and dump the entire API or check the changelog and see if there are any new OPS we need to support, if there are you need to add them to the allowlist.py and then also add tests to the allowlist_test.json.

If you can create a PR which shows some progress I will assign this to you.

Ok thanks i will start my work

On Mon, Dec 14, 2020, 6:04 AM Madhava Jay notifications@github.com wrote:

@devil-cyber https://github.com/devil-cyber, take a look at the merge
and pr tests.yml files for GitHub Actions.
Then go see the src/syft/lib/torch/allowlist.py:

allowlist["torch.Tensor.amax"] = {
"return_type": "torch.Tensor",
"min_version": "1.7.0",
}

What you need to do is import torch 1.7.1 and dir(torch) and dump the
entire API or check the changelog and see if there are any new OPS we need
to support, if there are you need to add them to the allowlist.py and
then also add tests to the allowlist_test.json.

If you can create a PR which shows some progress I will assign this to you.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenMined/PySyft/issues/4906#issuecomment-744099616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPIV6QKCHPMV2TOHA76QTDSUVMS5ANCNFSM4UZDRHNA
.

Hey @madhavajay for PyTorch 1.7.1 we have to add all API functionality
as well as we have to update the respective torch vision in the YML file.
Am I in the right direction?

@devil-cyber That is correct. If you can submit a PR with your progress I can give you feedback. 👍🏼

Ok, I will do that.

On Wed, Dec 23, 2020, 5:10 AM Madhava Jay notifications@github.com wrote:

@devil-cyber https://github.com/devil-cyber That is correct. If you can
submit a PR with your progress I can give you feedback. 👍🏼


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenMined/PySyft/issues/4906#issuecomment-749837595,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPIV6T5JYXUPYW2HW6VIRLSWEU67ANCNFSM4UZDRHNA
.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

iamtrask picture iamtrask  ·  4Comments

akirahirohito picture akirahirohito  ·  3Comments

samsontmr picture samsontmr  ·  3Comments

jvmncs picture jvmncs  ·  3Comments

iamtrask picture iamtrask  ·  3Comments