Pysyft: Set up CI for automated testing and style checks

Created on 12 Aug 2017  路  3Comments  路  Source: OpenMined/PySyft

Now that our codebase is growing (hooray!), we should set up CI for automated testing and style checks (PEP8, PEP257).

Choices include CircleCI and TravisCI. These can be integrated into our repo such that every pull request will be checked before review.

picture samsontmr

Most helpful comment

Quick question: Should the build fail if something violates PEP8/PEP257?

Yes!

picture samsontmr on 14 Aug 2017
👍3

All 3 comments

I have used Travis before and could set it up to run tests and check for any style guide violations tomorrow. Assign it to me if nobody else is already working on it.

Quick question: Should the build fail if something violates PEP8/PEP257?

dmonn picture dmonn on 14 Aug 2017

Quick question: Should the build fail if something violates PEP8/PEP257?

Yes!

samsontmr picture samsontmr on 14 Aug 2017
👍3

I would recommend using https://pypi.python.org/pypi/flake8

swaroopch picture swaroopch on 15 Aug 2017
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

durden62 picture durden62  路  3Comments
jvmncs picture jvmncs  路  3Comments
iamtrask picture iamtrask  路  3Comments
tblazina picture tblazina  路  3Comments
MetaT1an picture MetaT1an  路  3Comments