Pyfa: Feature request: Removed mods to be added to "recently used"

Created on 14 Mar 2018  路  5Comments  路  Source: pyfa-org/Pyfa

Suggestion

I would suggest that mods that are removed from a current fit should automatically be added to the "Recently Used Modules" view.

Motivation

If you play around with fits you often remove mods for testing. Having them available for quick refitting later in the "Recently Used Modules" view, helps to significantly speed up the process. Currently you need to find that module again on the market (if you remember which one it was), which can take some time. Btw. this is also the behavior of EFT, so many people will be used to this.

done enhancement

Most helpful comment

Fixed in 9be1b96226651a2e7557117648e6196a2e779877. Adding item to the "recent items" list triggers only when something gets added or removed explicitly. Here's list of items it can be triggered on:

  • modules / rigs / subsystems
  • drones / fighters
  • cargo items
  • implants
  • boosters

It means all projected items (modules, drones, fighters) and charges are ignored. Abyssal items are ignored too, since Recent list cannot store extended item info.

Here's list of actions which can trigger recent list for those items:

  • Adding item via double-click (previously it triggered only on this action)
  • Adding item via drag-n-drop (works for both single item and filling with item with Alt key)
  • Adding item via context menu (e.g. adding drones, or cargo)
  • Replacing module via drag-n-drop (single and multi with alt, adds to recents only item which replaces other items)
  • Removing item via double-click (single and multi)
  • Removing item with Del key
  • Removing item via context menu (single and multi)

Implicit removal of item does not trigger it. For example, it will trigger for subsystem you just added via market double-click or drag, but will not trigger for subsystem which was replaced by it; however if you remove subsystem manually, it will be added to the list. All not listed actions which modify items (price optimization, variations menu) do not trigger it.

All of the above is conscious decision rather than code forcing me to implement this way, so I can easily change it. If anyone thinks that doing it some other way would be more convenient, please post here.

Also implemented sorting by recency, it was using default market sorting before.

All 5 comments

I can get behind this, and I don't believe it would be too difficult. The biggest question would be how best to communicate that change to the market browser (which handles the recent modules list) from the fitting window. Thanks for the suggestion!

Any news on this enhancement? Is it still being considered?

This was created before I got back to maintaining pyfa. I think it's really nice to have (and at some point pyfa had this behavior) but it still needs to be coded. If anyone can do it - you're welcome.

I might have some time for it but much later. Will try to squeeze it into next release, but no promises.

Fixed in 9be1b96226651a2e7557117648e6196a2e779877. Adding item to the "recent items" list triggers only when something gets added or removed explicitly. Here's list of items it can be triggered on:

  • modules / rigs / subsystems
  • drones / fighters
  • cargo items
  • implants
  • boosters

It means all projected items (modules, drones, fighters) and charges are ignored. Abyssal items are ignored too, since Recent list cannot store extended item info.

Here's list of actions which can trigger recent list for those items:

  • Adding item via double-click (previously it triggered only on this action)
  • Adding item via drag-n-drop (works for both single item and filling with item with Alt key)
  • Adding item via context menu (e.g. adding drones, or cargo)
  • Replacing module via drag-n-drop (single and multi with alt, adds to recents only item which replaces other items)
  • Removing item via double-click (single and multi)
  • Removing item with Del key
  • Removing item via context menu (single and multi)

Implicit removal of item does not trigger it. For example, it will trigger for subsystem you just added via market double-click or drag, but will not trigger for subsystem which was replaced by it; however if you remove subsystem manually, it will be added to the list. All not listed actions which modify items (price optimization, variations menu) do not trigger it.

All of the above is conscious decision rather than code forcing me to implement this way, so I can easily change it. If anyone thinks that doing it some other way would be more convenient, please post here.

Also implemented sorting by recency, it was using default market sorting before.

Forgot to mention that original use-case might be covered by variations menu and undo/redo. But recently used still might be good for some fringe cases.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Altarus94 picture Altarus94  路  4Comments

leonbur picture leonbur  路  10Comments

MarHelmer picture MarHelmer  路  9Comments

sincomil picture sincomil  路  9Comments

MarHelmer picture MarHelmer  路  5Comments