Px4-autopilot: PX4 SITL hangs on error instead of exiting with error

[julianoes]

For the case where for instance the tool ant is not installed, PX4 SITL just seems to hang instead of exiting with an error. Only after pressing Ctrl+C twice, we are finally exited.

...
[100%] Built target px4
SITL ARGS
sitl_bin: /home/julianoes/src/Firmware/build/px4_sitl_default/bin/px4
debugger: none
program: jmavsim
model: none
src_path: /home/julianoes/src/Firmware
build_path: /home/julianoes/src/Firmware/build/px4_sitl_default
empty model, setting iris as default
SITL COMMAND: "/home/julianoes/src/Firmware/build/px4_sitl_default/bin/px4" "/home/julianoes/src/Firmware"/ROMFS/px4fmu_common -s etc/init.d-posix/rcS -t "/home/julianoes/src/Firmware"/test_data
INFO  [px4] Creating symlink /home/julianoes/src/Firmware/ROMFS/px4fmu_common -> /home/julianoes/src/Firmware/build/px4_sitl_default/tmp/rootfs/etc
0 WARNING: setRealtimeSched failed (not run as root?)

______  __   __    ___ 
| ___ \ \ \ / /   /   |
| |_/ /  \ V /   / /| |
|  __/   /   \  / /_| |
| |     / /^\ \ \___  |
\_|     \/   \/     |_/

px4 starting.

INFO  [px4] Calling startup script: /bin/sh etc/init.d-posix/rcS 0
/home/julianoes/src/Firmware/Tools/jmavsim_run.sh: line 61: ant: command not found
  SYS_AUTOSTART: curr: 0 -> new: 10016
  ...
  PWM_MIN: curr: 1000 -> new: 1075
INFO  [dataman] Unknown restart, data manager file './dataman' size is 11405132 bytes
INFO  [simulator] Waiting for simulator to connect on TCP port 4560
^CERROR [px4] Startup script returned with return value: 2
pxh> 
Exiting...
pxh> Shutting down
/home/julianoes/src/Firmware/Tools/sitl_run.sh: line 164: kill: (22035) - No such process
make[4]: *** [platforms/posix/CMakeFiles/jmavsim.dir/build.make:57: platforms/posix/CMakeFiles/jmavsim] Error 1
make[3]: *** [CMakeFiles/Makefile2:20576: platforms/posix/CMakeFiles/jmavsim.dir/all] Interrupt
make[2]: *** [CMakeFiles/Makefile2:20583: platforms/posix/CMakeFiles/jmavsim.dir/rule] Interrupt
make[1]: *** [Makefile:6346: jmavsim] Interrupt
make: *** [Makefile:171: px4_sitl_default] Interrupt

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[julianoes]

I hate this bot.