Pwa-studio: [bug]: npx bundlesize will result in error

[Jordaneisenburger]

Describe the bug
When you want to check the bundleSize this it will result in an error:
There is no matching file for ./packages/venia-concept/dist/js/{client,vendor}.js in /Users/jordan/experius/domains/pwa-studio

To Reproduce
Steps to reproduce the behavior:

1. run npx bundlesize
2. See error

Expected behavior
Show PASS for all defined files

Additional context
The reason this bug happens is because inside the newly created packages/pwa-buildpack/lib/WebpackTools/configureWebpack.js at line 102 js/ is removed.

Possible solutions
See https://github.com/magento/pwa-studio/issues/1542#issuecomment-538468098.

Please let us know what packages this bug is in regards to:

• [x] venia-concept
• [x] pwa-buildpack
• [ ] peregrine
• [ ] pwa-devdocs
• [ ] upward-js
• [ ] upward-spec

[sirugh]

I think this can be fixed by just removing js/ from the bundlesize config paths in the root package.json.

That said, we might want to consider updating these as I don't think they make sense anymore and we generate many more bundles than this checks. For example, there are the RootCmp files we should check along with sw.js and the renamed vendor~client-[0-9]+.js file.

[supernova-at]

To populate the venia-concept/dist folder, run yarn build.

New paths are of the following form:

We want to update the bundlesize entries in package.json to match these filenames:

  "bundlesize": [
    {
      "path": "./packages/venia-concept/dist/js/{client,vendor}.js",
      "maxSize": "250 kB"
    },
    {
      "path": "./packages/venia-concept/dist/js/[0-9]-*.js",
      "maxSize": "100 kB"
    }
  ]

[RanadeepPolavarapu]

I'll take this.