Pwa-studio: [Styles]: Close button displayed incorrect for cart

[vitalics]

This issue is for the following packages:

[X] venia-concept
[ ] pwa-buildpack
[ ] peregrine
[ ] pwa-devdocs
[ ] upward-js
[ ] upward-spec

This issue is a:

[X] Bug
[ ] Feature suggestion
[ ] Documentation issue
[ ] Other (Please Specify)

Environment

| Question | Answer |
| --------------------------- | :-----------: |
| Magento version | |
| Operating System + version | |
| node.js version (node -v) | |
| npm version (npm -v) | |

Description

close cart button displayed incorrect as you can see on screenshot below

Expected result:

Possible solutions:

in class miniCart-header fix styles:

.miniCart-header{
    grid-template-columns: 0.9fr; /* was 1fr */
    justify-content: end; /* remove this style rule */
}

[codeAdrian]

Hello, I have submitted PR which fixes this issue: https://github.com/magento-research/pwa-studio/pull/600

[ericerway]

Fantastic, thanks @codeAdrian! Every contribution counts.

[vitalics]

Update. Production check. this issue was fixed, close button displaying correctly:

Reason for close. Fixed

[codeAdrian]

Hello, thanks for confirming the fix. I'm just wondering if we should keep the issue open until PR has been approved and merged? Maybe @ericerway can correct me if I'm wrong. Since issues are synced with Zenhub and used for tracking fixes and features.