Probot: [TypeScript Fix app.on webhooks autocompletion

[brunolemos]

Please make the autocompletion on probot as good as @octokit/webhooks or better.

PS: I'm already using Probot 8.0.0-beta.7 (#826) cc @gr2m
Should not be hard since it's already using @octokit/webhooks now.

Here's a comparison:

event names autocompletion

@octokit/webhooks autocompletes

probot doesn't autocomplete

payload autocompletes based on the event name

@octokit/webhooks does it right

probot always autocomplete the same payload definition for all events

Which is wrong, for example this one should have a repositories array:

This one should have a comment:

Environment

• Probot version(s): 8.0.0-beta.7
• Node/npm version: 11.5.0
• OS: OSX 10.14.3

Possible Solution
Reuse the type definitions from @octokit/webhooks.

[welcome[bot]]

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

[wolfy1339]

I have opened #858 to do this work, i've gotten some progress, but things don't work. Feel free to help out!

[probotbot]

:tada: This issue has been resolved in version 8.0.0-beta.11 :tada:

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: