Privacytools.io: 馃寪 Website Issue | Icons out of place on mobile devices

Created on 5 May 2019  路  4Comments  路  Source: privacytools/privacytools.io

Description

Icons look out of place currently on mobile devices.

Screenshots

Looks neat:
good

Does not look neat at all:
bad

high priority 鈩癸笍 help wanted 馃寪 website issue

Most helpful comment

I'm not that good with BS4 but basically we want the buttons and the icons to be in the same div (maybe .row or .col-12) and put the buttons and the icons in separate divs, something like div.col-md-6. And also make the icons section right aligned (ideally with flexbox) but center aligned (.justify-content-center) when the div "collapses" (when size is < md).

Currently the icons are right-aligned using .float-right. I think we should avoid floats as much as possible and use the BS4 grid instead.

Perhaps @Vincevrp or @JonahAragon could be able to implement this (assuming you're not busy)?

All 4 comments

I have no idea how would I start fixing this, so I am unassigning myself and setting "help wanted" label.

I'm not that good with BS4 but basically we want the buttons and the icons to be in the same div (maybe .row or .col-12) and put the buttons and the icons in separate divs, something like div.col-md-6. And also make the icons section right aligned (ideally with flexbox) but center aligned (.justify-content-center) when the div "collapses" (when size is < md).

Currently the icons are right-aligned using .float-right. I think we should avoid floats as much as possible and use the BS4 grid instead.

Perhaps @Vincevrp or @JonahAragon could be able to implement this (assuming you're not busy)?

They should probably be left aligned on mobile, not centered. I鈥檒l see if I have time to take a look later if nobody else figures it out, but I鈥檓 sure there鈥檚 some way to do that that鈥檚 built-in to BS4.

Definitely need to switch to the grid system if that isn鈥檛 what we鈥檙e currently using anymore.

thanks for fixing this @dawidpotocki

Was this page helpful?
0 / 5 - 0 ratings

Related issues

0verk1ll picture 0verk1ll  路  3Comments

Echo1707 picture Echo1707  路  3Comments

BurungHantu1605 picture BurungHantu1605  路  3Comments

AshTex picture AshTex  路  3Comments

johnozbay picture johnozbay  路  3Comments