Prettier-vscode: Getting warning about deprecated options when they're removed

[babramczyk]

Summary

I started getting warnings about deprecated settings for prettier config in my global VS code settings. So, I removed them. However, every time I format any file, I still get this warning:

Clicking "Remove Settings" seems to do nothing, as well as "Migrate Settings". I have ensured that no prettier config is set in my VS Code config file any more

[ntotten]

Can you post the output log for the extension so I can see what might be happening?

[babramczyk]

Sure thing.

```
[INFO - 11:11:54 AM] Formatting /Users/abr1402/nml/exam-connect-ma/client/components/ClientDetails/ClientDetails.jsx.
[INFO - 11:11:54 AM] Loaded module '[email protected]' from '/Users/abr1402/nml/exam-connect-ma/node_modules/prettier/index.js'.
[INFO - 11:11:54 AM] Resolved ignore file to /Users/abr1402/nml/exam-connect-ma/.prettierignore.
[INFO - 11:11:54 AM] File Info:
{
"ignored": false,
"inferredParser": "babel"
}
[INFO - 11:11:54 AM] Prettier Options:
{
"filepath": "/Users/abr1402/nml/exam-connect-ma/client/components/ClientDetails/ClientDetails.jsx",
"parser": "babel",
"semi": false,
"singleQuote": true,
"trailingComma": "all"
}
[INFO - 11:11:54 AM] Formatting completed in 57.211924ms.

[Drageaux]

I just ran into the same thing. It was working just fine yesterday

[shoesandsocks]

Not sure if "same" comments are helpful, but.... same. My output log looks similar to above; nothing immediately/obviously wrong.

[ntotten]

I just pushed a small update that added a bit more logging. If you could update to version 3.3.2 and paste your output logs that will be helpful. Thanks!

[babramczyk]

Updated logs for 3.3.2:

[INFO - 12:50:46 PM] Extension Name: "prettier-vscode".
[INFO - 12:50:46 PM] Extension Version: "3.3.2".
[INFO - 12:50:46 PM] Loaded module '[email protected]' from '/Users/abr1402/nml/exam-connect-ma/node_modules/prettier/index.js'.
[INFO - 12:50:46 PM] Enabling prettier for languages:
[
  "javascript",
  "javascriptreact",
  "typescript",
  "typescriptreact",
  "json",
  "jsonc",
  "json5",
  "css",
  "postcss",
  "less",
  "scss",
  "graphql",
  "markdown",
  "mdx",
  "html",
  "vue",
  "yaml"
]
[INFO - 12:50:46 PM] Enabling prettier for range supported languages:
[
  "javascript",
  "javascriptreact",
  "typescript",
  "typescriptreact",
  "json",
  "graphql"
]
[INFO - 12:50:48 PM] Formatting /Users/abr1402/nml/exam-connect-ma/client/components/ClientDetails/ClientDetails.jsx.
[INFO - 12:50:48 PM] Loaded module '[email protected]' from '/Users/abr1402/nml/exam-connect-ma/node_modules/prettier/index.js'.
[INFO - 12:50:48 PM] Resolved ignore file to /Users/abr1402/nml/exam-connect-ma/.prettierignore.
[INFO - 12:50:48 PM] File Info:
{
  "ignored": false,
  "inferredParser": "babel"
}
[INFO - 12:50:48 PM] Prettier Options:
{
  "filepath": "/Users/abr1402/nml/exam-connect-ma/client/components/ClientDetails/ClientDetails.jsx",
  "parser": "babel",
  "semi": false,
  "singleQuote": true,
  "trailingComma": "all"
}
[INFO - 12:50:48 PM] Formatting completed in 138.591443ms.

[babramczyk]

As a side note, is there a place I could be directed to to see the discussion on why configuring Prettier through VS Code config was removed? Don't mean to derail this issue, but curious on the reasoning there (since I found that functionality useful) 🙂

[ntotten]

@babramczyk The version 3 discussion was mostly here: #958.

The short of it is, the fundamental philosophy was we wanted to make the extension and the CLI behave exactly the same in the same project. So if you formatted in VS Code or by running prettier you would have the same output. By putting VS Code specific settings, that isn't possible.

There also were A LOT of bugs and questions around how the configuration was applied, what order t was applied, and for my sanity of maintaining the project, I wanted it to be more straight forward and just be the same as prettier.

[ntotten]

I made the removal less error prone in version 3.3.3. I think the issue is that there might be a setting that has a weird value like prettier.tabWidth: null or something. Previously, I was checking to see if the values were valid before clearing them, but there really wasn't any reason to check. Once you click "Remove Settings" it will just remove them all regardless of whatever value they have set.

Give it a try in 3.3.3 and let me know if the problem goes away. Thanks!

[saadelsabahy]

all work
Add icon to statusBar in vs code

[babramczyk]

Still not working for me. FWIW, before I submitted this issue, I already confirmed I had no root-level "prettier.*" config options in my VS Code config file.

Log on 3.3.3:

[INFO - 2:07:49 PM] Formatting completed in 425.990476ms.
[INFO - 2:07:51 PM] Removed setting 'prettier.printWidth' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.tabWidth' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.singleQuote' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.trailingComma' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.bracketSpacing' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.jsxBracketSameLine' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.semi' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.useTabs' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.proseWrap' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.arrowParens' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.jsxSingleQuote' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.htmlWhitespaceSensitivity' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.endOfLine' from any configurations.
[INFO - 2:07:51 PM] Removed setting 'prettier.quoteProps' from any configurations.
[INFO - 2:07:51 PM] Formatting /Users/abr1402/nml/exam-connect-ma/client/components/ClientDetails/ClientDetails.jsx.
[INFO - 2:07:51 PM] Loaded module '[email protected]' from '/Users/abr1402/nml/exam-connect-ma/node_modules/prettier/index.js'.
[INFO - 2:07:51 PM] Resolved ignore file to /Users/abr1402/nml/exam-connect-ma/.prettierignore.
[INFO - 2:07:51 PM] File Info:
{
  "ignored": false,
  "inferredParser": "babel"
}
[INFO - 2:07:51 PM] Prettier Options:
{
  "filepath": "/Users/abr1402/nml/exam-connect-ma/client/components/ClientDetails/ClientDetails.jsx",
  "parser": "babel",
  "semi": false,
  "singleQuote": true,
  "trailingComma": "all"
}
[INFO - 2:07:51 PM] Formatting completed in 69.790352ms.

[ntotten]

@babramczyk It is unclear to me why this would be happening. Is it possible you have a setting that is set globally and maybe the file permissions are such that the extension isn't able to remove the setting?

The places the settings could be are:

1. ./vscode/settings.json
2. In your .code-workspace files: https://code.visualstudio.com/docs/editor/multi-root-workspaces#_settings
3. In your vscode global user settings: https://code.visualstudio.com/docs/getstarted/settings#_settings-file-locations

And to clarify, you still see the warning every time you save a file in the project even after you clicked "Remove Settings"?

[babramczyk]

I have checked all three locations, and there are no root-level prettier config settings in them. My project level ./vscode/settings.json is empty, and I have no .code-workspace files.

And to clarify, you still see the warning every time you save a file in the project even after you clicked "Remove Settings"?

Yes, it still happens after I click "Remove Settings".

Here is my entire global config if helpful.

{
  // Exlude files
  "files.exclude": {
    "*.gitmodules*": true,
    "*.idea*": true,
    "*.swp*": true,
    "**/.DS_Store": true,
    "**/.git": true,
    "**/.vscode": true,
    "**/node_modules": true
  },
  "search.exclude": {
    "**/node_modules": true,
    "**/bower_components": true,
    "**/deploy": true,
    "**/build/**": true
  },
  "editor.minimap.enabled": false,
  "editor.quickSuggestions": {
    "other": true,
    "comments": false,
    "strings": false
  },
  "editor.fontFamily": "FiraCode-Retina",
  "editor.fontLigatures": true,
  "editor.rulers": [80],
  "editor.scrollBeyondLastLine": true,
  "explorer.autoReveal": false,
  "explorer.sortOrder": "type",
  "files.autoSave": "onFocusChange",
  "git.confirmSync": false,
  "search.smartCase": true,
  "workbench.iconTheme": "material-icon-theme",
  // Extensions
  "material-icon-theme.folders.theme": "specific",
  "sync.gist": "51ee4570bd49ca1203a3623c9ee51ce8",
  "sync.removeExtensions": true,
  "sync.syncExtensions": true,
  // ESLint
  "eslint.run": "onType",
  "eslint.options": {
    "rules": {
      // Possible errors
      "no-unreachable": 1,
      "no-unused-vars": 1,
      "prettier/prettier": 0,
      "no-empty": 0,
      "no-console": 0
    }
  },
  "git.autofetch": true,
  "editor.tabSize": 2,
  "editor.acceptSuggestionOnEnter": "off",
  "editor.quickSuggestionsDelay": 100,
  "javascript.suggestionActions.enabled": true,
  "explorer.confirmDragAndDrop": false,
  "material-icon-theme.showReloadMessage": false,
  "javascript.updateImportsOnFileMove.enabled": "always",
  "breadcrumbs.enabled": true,
  "breadcrumbs.symbolPath": "off",
  "editor.fontSize": 14,
  "git.allowForcePush": true,
  "git.alwaysShowStagedChangesResourceGroup": true,
  "editor.parameterHints.enabled": false,
  "workbench.fontAliasing": "auto",
  "diffEditor.renderSideBySide": false,
  "typescript.format.enable": false,
  "search.useReplacePreview": false,
  "workbench.sideBar.location": "left",
  "editor.acceptSuggestionOnCommitCharacter": false,
  "typescript.updateImportsOnFileMove.enabled": "always",
  "eslint.validate": [
    "javascript",
    "javascriptreact",
    "typescript",
    "typescriptreact",
    "vue",
    "html"
  ],
  "git.openDiffOnClick": false,
  "togglequotes.chars": ["\"", "`", "'"],
  "editor.wrappingIndent": "indent",
  "terminal.integrated.rendererType": "canvas",
  "terminal.integrated.cursorBlinking": true,
  "editor.suggestSelection": "recentlyUsedByPrefix",
  "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
  "editor.suggest.maxVisibleSuggestions": 8,
  "editor.snippetSuggestions": "bottom",
  "[json]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[jsonc]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[javascript]": {
    "editor.fontLigatures": "'ss02', 'ss19'",
  },
  "sync.autoUpload": true,
  "atomKeymap.promptV3Features": true,
  "editor.multiCursorModifier": "ctrlCmd",
  "sync.quietSync": true,
  "[html]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "git.enableSmartCommit": true,
  "workbench.startupEditor": "none",
  "workbench.colorTheme": "Over Night Owl",
  "merge-conflict.diffViewPosition": "Below",
  "window.zoomLevel": 0,
  "extensions.ignoreRecommendations": false,
  "html.format.enable": false,
  "terminal.integrated.fontSize": 14,
  "vetur.format.defaultFormatter.html": "prettier",
  "sync.forceUpload": true,
  "vetur.validation.script": false,
  "editor.suggest.localityBonus": true,
  "workbench.editor.showTabs": true,
  "browser-preview.startUrl": "http://localhost:3000",
  "editor.cursorSurroundingLines": 3,
  "editor.formatOnSave": true,
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "debug.console.fontSize": 14,
  "jest.autoEnable": false,
  "jest.runAllTestsFirst": false,
  "standard.enable": false,
  "javascript.format.enable": false,
  "editor.wordWrap": "wordWrapColumn",
  "task.problemMatchers.neverPrompt": true,
  "git.untrackedChanges": "separate",
  "liveServer.settings.donotShowInfoMsg": true
}

[gotofritz]

FYI, I was having the same issue, I solved it by going in my settings file and removing all occurrences of "prettier.xxx": ...,. So far it's working fine again.

[RealDyllon]

@gotofritz 's solution sort of worked. Prettier now works when i use the "format document" keyboard shortcut.

But now, there's no checkmark for prettier on the lower right corner of my status bar.

[ntotten]

VS code config options were added back in 3.4.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.