Prettier-vscode: Bug: Ignores option jsxBracketSameLine and format is odd

[DanielHabenicht]

I've got a formatting problem since today, without changing anything in my config. Prettier turned this:

<button *ngFor="let webPage of webPages" class="dropdown-item" (click)="navigateToPage(webPage)">{{webPage}}</button>
<button class="btn btn-clean" (click)="createNewPage()">
  <i class="icon icon-add icon-md mr-1"></i>
  <ng-container i18n="@@HeaderComponentButtonNewPage">
    Create new Page
  </ng-container>
</button>

into this:

<button
  *ngFor="let webPage of webPages"
  class="dropdown-item"
  (click)="navigateToPage(webPage)"
>
  {{ webPage }}
</button>
<button class="btn btn-clean" (click)="createNewPage()">
  <i class="icon icon-add icon-md mr-1"></i>
  <ng-container i18n="@@HeaderComponentButtonNewPage"
    >Create new Page</ng-container
  >
</button>

I've disabled all other Extensions and stripped my VSCode settings to only this line, but still the same result:

{
  "prettier.jsxBracketSameLine": true
}

Apart from ignoring the VSCode Setting for prettier.jsxBracketSameLine I don't think that this is supposed to be:

</ng-container
  >

VSCode Version: 1.28.2 | Prettier Version: 1.7.1

Just for reference, I opened a Stackoverflow aswell.

[CiGit]

this is only valid for jsx

There is discussed in prettier: https://github.com/prettier/prettier/issues/5377
There is nothing we can do in this extension about that.

[DanielHabenicht]

Ok, thanks for the quick response.
So the update to a higher prettier version actually introduced the change in functionality?

[CiGit]

Prettier didn't format template before that version

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.