Prettier-atom: support markdown from prettier 1.8

Created on 8 Nov 2017  路  7Comments  路  Source: prettier/prettier-atom

Hey folks! I'd love to get support for markdown from prettier 1.8. I did a little digging and I think that I found all the places that need a change:

  1. Around here we need another if statement
  2. Around here we need a isCurrentScopeMarkdownScope (and export that below)
  3. Around here we need a getMarkdownScopes (and add that to the export below and include it in getAllScopes).
  4. Around here we need a markdownScopes thing like the others.

I'm pretty sure that should do it. Anyone wanna take that?

enhancement good first issue help wanted

Most helpful comment

We should add this information to CONTRIBUTING.md.

All 7 comments

If you've never done atom plugin dev before, this could help (and the official guide).

@kentcdodds I have never done atom plugin dev before, am I still allowed to take this up?

Absolutely! It'll be a learning experience for sure! Good luck!

Make sure to check the CONTRIBUTING.md file :+1:

And please make sure to add tests :)

Definitely! Do you have a suggestion for where those should go @robwise?

Pretty much each file has its own corresponding test file, with the exception of src/main.js. We keep the test files right next to the source files (as opposed to inside a __tests__ folder, although that probably would have been cleaner). It should hopefully be clear from glancing at those how and where to test what you added, as adding new language/parser support this is a pretty common pattern by now.

The only exception would be the atomInterface file since that's at the edge where we actually call to Atom, which doesn't exist so there's not really much to test, although you could.

We should add this information to CONTRIBUTING.md.

Was this page helpful?
0 / 5 - 0 ratings