Prettier-atom: ESLint Integration option shouldn't crash without ESLint config
I have one project which uses ESLint and the other one which doesn't, but I want to cover both without having to switch the "ESLint Integration" option on and off. I suggest altering the behavior of it to not crash without ESLint config, but instead to fall back to regular prettier.
What do you think?
silvenon
All 5 comments
Yeah absolutely, we should do this. I would almost consider it a bug. Do we need an option like Fallback to prettier if no ESlint configuration found?
robwise
on 6 Mar 2017
I don't think the option is necessary, it's very intuitive and in my opinion always desired behavior. Unless there's an edge case that I'm overlooking.
silvenon
on 6 Mar 2017
@silvenon I was thinking that it might be confusing if they check "ESlint Integration" and then we don't actually do the integration in some cases, but I can just maybe add that in the description and skip the option?
robwise
on 6 Mar 2017
That would make sense to me, yes.
silvenon
on 6 Mar 2017
I'm going to close this because right now prettier-eslint now does this automatically. Keep an eye out for this though: https://github.com/prettier/prettier-eslint/issues/72
robwise
on 22 Apr 2017
Related issues
axhamre
路
4Comments
Andersos
路
6Comments
ryanpcmcquen
路
3Comments
iamphill
路
5Comments
derwaldgeist
路
5Comments
Most helpful comment
@silvenon I was thinking that it might be confusing if they check "ESlint Integration" and then we don't actually do the integration in some cases, but I can just maybe add that in the description and skip the option?