Prestashop: Fix error when updating a used address with no DNI

[shaffe-fr]

Describe the bug

When the DNI required settings is turned on, existing used addresses with no DNI cannot be updated.

Expected behavior

When I update the missing DNI field of an address used in an order, I expect the used address to be updated silently (with the deleted flag set to 1) and I expect a new address to be created.

Steps to Reproduce

Steps to reproduce the behavior:

1. Ensure that the DNI to not required for the default country in International > Locations > Countries (no dni in the address format and Do you need a tax identification number? set to No)
2. Create a customer address for this country
3. Create an order and use the address created at step 2
4. Set the DNI to required for the country's address in International > Locations > Countries (add dni to the address format and set Do you need a tax identification number? to Yes)
5. Update the customer address and fill the DNI field
6. See error

Additional information

• PrestaShop version: 1.7.7, develop
• PHP version: N/A

[shaffe-fr]

A PR fix is available #18697

[sam-pires]

@PrestaShop/prestashop-product-team I think we should have a look at the expected behaviors to make sure we don't miss something. A PR is available, the sooner, the better.
ping @LouiseBonnard (you commented the PR ;))

[shaffe-fr]

The annoying thing with this issue is that there is no workaround for shop administrators.

I did not test it, but there is maybe a similar bug when setting up required fields from the bottom of the addresses admin section. Should I create another issue or extend the scope of the issue and PR?

[LouiseBonnard]

And the other issue is that the expected behavior regarding address formats does not seem to be specified on our end... does it only concern the DNI field or any other field lately set as required? We must investigate before making any decision, I'll try to do it by the end of the week. :-)

[marsaldev]

I would add another problem, this behaviour happens also for the supplier address, if you set the DNI mandatory (and the supplier address doesn't have DNI) you'll receive an error when save it 😊
I think it's linked.
(the affected version are also the 1.7.6 and before)

[LouiseBonnard]

Another nice inconsistency, aha, thanks for the feedback, @marsaldev! It seems to happen only for the DNI field... alright, let's change that!

[marionf]

Guys, are we sure it's not a regression of the 1.7.7 ?

[marsaldev]

To be more specific about the supplier, in the form (new or edit) you'll see also the DNI field and you need to write something 😊
Even more, if there is a module that makes check on that field you must insert a valid DNI XD

[LouiseBonnard]

Hi all, the great @marionf has managed to reproduce this bug, see screenshot in the issue description. It is a regression, introduced by the 1.7.7. @shaffe-fr, would you mind rebasing your pull request on the 1.7.7.x branch?

Regarding the required fields you can set at the end of the Customers > Addresses page, if you experienced the same bug, please open a new issue so that it can be qualified by the teams. ;-)

@marsaldev, we could not reproduce the same bug for suppliers, we guess it has been solved by #17305.

[shaffe-fr]

Hi @LouiseBonnard, the PR is updated.
About the required fields set in the database, I'll check if there is an issue and I'll create a new issue and PR.

[Progi1984]

Fixed by #18697 (@shaffe-fr)

[shaffe-fr]

Hi,
I just upgraded a PrestaShop from 1.7.5 to 1.7.6.5 and I was able to reproduce the bug on that branch.
@Progi1984, maybe the PR should be cherry-picked on the 1.7.6 branch?