Prestashop: Missing Bank data in email confirmation

[Betafer]

I got missing data in email confirmatio:

As you can see in the image are displayed: {bankwire_owner} {bankwire_details} {bankwire_address}
instead of Bank details, the module version is v2.0.4 di PrestaShop

I think the problem is in resend email botton:

• PrestaShop version: 1.7.6.3
• PHP version: 7.2

[khouloudbelguith]

Hi @Betafer,

I did not manage to reproduce the issue with PS1.7.6.4 and the Bank transfer module v2.0.4
I attached a screen record
https://drive.google.com/file/d/1Tbv5iWdVfOA5Ywg_kY7lPv4YE4f24llW/view?usp=sharing
Thanks to check and feedback.

[maofree]

Hi
I get the same problem on another website with Bank transfer module v2.0.4 and prestashop 1.7.6.1
the problem of this issue is that it happens randomly. So I set that data in the html email of the module bankwire

there are no big differences between 1.7.6.1 and 1.7.6.4

[khouloudbelguith]

@Betafer, @maofree, it is simlar to this issue: https://github.com/PrestaShop/PrestaShop/issues/16741
But, I couldn't reproduce the issue with the provided information with the Classic template and modern template.

Thanks!

[Betafer]

Hi @Betafer,

I did not manage to reproduce the issue with PS1.7.6.4 and the Bank transfer module v2.0.4
I attached a screen record
https://drive.google.com/file/d/1Tbv5iWdVfOA5Ywg_kY7lPv4YE4f24llW/view?usp=sharing
Thanks to check and feedback.

Try to set some data in bank details

[Betafer]

Another order received from another country and another language, same problem.
Just Now

[khouloudbelguith]

@Betafer, data is well set as you can see in my screen record

Did you use an address mail with uppercase?
Try to navigate to the BO => Design => Email theme and try to generate emails for your language.
Thanks!

[Betafer]

No uppercase in email.
What happens if i regenerate my emails?
 Will there be any changes if there are any changes?

[maofree]

Hi @khouloudbelguith
sometimes there are some strange bugs that you cannot reproduce each time on your demo site.
I think these two examples are not the only ones.
so you should recheck all code that manage the confirmation step to remove all possible issue
however there are two sites with two different themes and servers that has the same issue

If I do some tests on my demo site I cannot reproduce this issue too

[Betafer]

@Betafer, data is well set as you can see in my screen record

Did you use an address mail with uppercase?
Try to navigate to the BO => Design => Email theme and try to generate emails for your language.
Thanks!

This is the email sent form order confirmation or form the resend email button ?

[khouloudbelguith]

@Betafer,

This is the email sent form order confirmation or form the resend email button?

I checked two options => OK
https://drive.google.com/file/d/1qMlyDMFPn-U7ms3jnWw3l-kx3-9IOeaG/view?usp=sharing

@maofree,

however there are two sites with two different themes and servers that has the same issue

It couldn't be related to your theme or custom modules?

Thanks!

[maofree]

the themes in the order confirmation has no faults, if prestashop send the bankwire email
and the same is for the extra modules.
if the order is ok and the problem is only on the bankwire only on its details (not on the data of the customer), theme and extra modules are not the problem.
the problem is why prestashop in some cases cannot pass the 3 bankwire variables to the emails?
the email templates also are not the problem, if not it should be present always

[khouloudbelguith]

@maofree,

We need to retrieve the PHP error log and the debug mode report in order to find out what's wrong.
Don't you know how to get this information? Please read the following article:
http://build.prestashop.com/howtos/misc/how-to-create-bug-report/

Thanks!

[maofree]

sorry but which log can write the motive of why just one part of the data is passed to the email and the other of the module variables are not?
I'll pass to the next bug, with these answers it is not possible to fix anything
bye

[khouloudbelguith]

@maofree, I need all information that could be helpful for us to reproduce the issue.

• any errors in the log could help us?
• in which language this issue occurs?
• Is the employee and the Customer have the same languages? is it the default language?

Thanks for your understanding!

[Betafer]

This is the same issue #16741

As i told you 2 languages: Italian and french (order)

[khouloudbelguith]

@Betafer tried with the Italian language "email sent form order confirmation" or "form the resend email button"
=> OK

Thanks!

[Betafer]

write data in the bankwire module and recheck please

[Betafer]

Retested, confirmation email data ara ok, resend email from backoffice bank data are missing
Tested with backoffice in english and also in italian.

[khouloudbelguith]

@Betafer, I attached a screen record
https://drive.google.com/file/d/1UtMlAu5Yxr5aUjUwYEDl9Xi5HZedRvU5/view?usp=sharing

We need to retrieve the PHP error log and the debug mode report in order to find out what's wrong.

Thanks!

[Betafer]

There are no error in log files related to this:

[Thu Apr 09 12:46:31.557039 2020] [fcgid:warn] [pid 38262] (32)Broken pipe: [client 37.116.119.15:59785] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 12:46:32.137579 2020] [fcgid:warn] [pid 38280] (32)Broken pipe: [client 37.116.119.15:59783] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 12:46:32.647551 2020] [fcgid:warn] [pid 38286] (32)Broken pipe: [client 37.116.119.15:59781] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 12:46:33.115169 2020] [fcgid:warn] [pid 39894] (32)Broken pipe: [client 37.116.119.15:59782] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 12:46:33.625465 2020] [fcgid:warn] [pid 38245] (32)Broken pipe: [client 37.116.119.15:59784] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 12:46:34.287152 2020] [fcgid:warn] [pid 43689] (32)Broken pipe: [client 37.116.119.15:59780] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 15:17:48.165856 2020] [fcgid:warn] [pid 49996] (32)Broken pipe: [client 37.116.119.15:60715] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 15:17:48.742659 2020] [fcgid:warn] [pid 54049] (32)Broken pipe: [client 37.116.119.15:60718] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 15:17:49.756074 2020] [fcgid:warn] [pid 38262] (32)Broken pipe: [client 37.116.119.15:60717] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 15:17:50.397791 2020] [fcgid:warn] [pid 54047] (32)Broken pipe: [client 37.116.119.15:60721] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 15:17:51.057574 2020] [fcgid:warn] [pid 54021] (32)Broken pipe: [client 37.116.119.15:60719] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 15:17:51.722574 2020] [fcgid:warn] [pid 48615] (32)Broken pipe: [client 37.116.119.15:60720] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c
[Thu Apr 09 15:17:52.506988 2020] [fcgid:warn] [pid 53942] (32)Broken pipe: [client 37.116.119.15:60716] mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: /index.php?controller=AdminPageCacheConfiguration&token=d6104e92b6f8670e5c6b0606b3c2851c

[Betafer]

Can you try with my datas please:
Account owner: Betafer snc
Account details:
BANCA POPOLARE DELL'ALTO ADIGE
IBAN: IT72 T058 5661 2300 2257 1232 270
BIC/SWIFT: BPAAIT2B022
Come filiale della banca, codice IBAN, BIC, ecc

Bank address:
Via Ferdinando Coletti 15, Tai Di Cadore
0435 505600

[khouloudbelguith]

@Betafer, tried with your data => OK
https://drive.google.com/file/d/1AHwQTF9jFDPXJLLIZU36mi4kTJDCdX9x/view?usp=sharing

Thanks!

[Betafer]

In my opinion it's a problem due to the prestashop update, and I think in the database.
How does that button work, where does it get your bank details from?
Why does the order email work and the button email doesn't? Don't they work the same way?

[khouloudbelguith]

@Betafer, did you made an upgrade from a previous PrestaShop version?

• What is the exact Previous PrestaShop version?
• What is the exact version of the 1-click upgrade did you use?

Thanks!

[Betafer]

Was: 1.5.6.3
did not remember, the version of 1 click done in January

[Betafer]

Found this in prestashop forum:
PrestaShop Newbie
PrestaRob
Members
0
3 posts
Report post
Posted May 14, 2018
Hello,

if you need bankwire variables usable in any mail template with any order status, you need to edit file //PrestaFolder/classes/Mail.php

Find the line starting with:

$template_vars['{color}']
And below that line add this piece of code:

/* MK-VISION.CZ BANKWIRE MAIL VARIABLES */
$template_vars['{bankwire_owner}'] = Configuration::get('BANK_WIRE_OWNER');
$template_vars['{bankwire_details}'] = nl2br(Configuration::get('BANK_WIRE_DETAILS'));
$template_vars['{bankwire_address}'] = nl2br(Configuration::get('BANK_WIRE_ADDRESS'));
I have tested it with Prestashop 1.6.1.3. Let me know if that helped.

Have a nice day.

Hi Talas,

In Presta 1.7, the variable $template_vars has been renamed to $templateVars (declared and instantiated around line 536 of classes/Mail.php)

So you can take what PrestaRob wrote and change the variable name from $template_vars to $templateVars.

I have tested this in 1.7.4.2 and there is nothing in the change-logs about mails for the 1.7.5 so this should work fine on your version.

Have a nice day.

Can you please ask a programmer to make this fix in next prestashop version ?

[khouloudbelguith]

@Betafer, could you please check your file /Project_Folder/classes/Mail.php and verify if it is similar to this
https://github.com/PrestaShop/PrestaShop/blob/1.7.6.3/classes/Mail.php?

Thanks!

[Betafer]

[Betafer]

Those variables are not correctly passed from the bankwire module to the module that manages the sending of the emails.

[khouloudbelguith]

@Betafer, could you please provide me the exact link of the forum of this comment..

Thanks!

[Betafer]

Here:
https://www.prestashop.com/forums/topic/552558-bank-wire-details-dont-show-on-status-email/

The problem is still present from version 1.2 of prestashop:
https://www.prestashop.com/forums/topic/24753-problema-email-pagamento-bonifico-da-bo/

There are many topics related to this:
https://www.google.com/search?q=%7Bbankwire_owner%7D+site:www.prestashop.com&sxsrf=ALeKk00mkAYGTsOA6XfTPLqvnUwTeJlIpA:1586517860032&sa=X&ved=2ahUKEwi1iujL393oAhWSM-wKHXt6AxsQrQIoBDAAegQIBBAR&biw=1996&bih=1050

[khouloudbelguith]

@Betafer, thanks!

In my case not reproduced but I will ping our devs to check the fix.
Ping @PrestaShop/prestashop-core-developers what do you think of this fix:

if you need bankwire variables usable in any mail template with any order status, you need to edit file //PrestaFolder/classes/Mail.php

Find the line starting with:

$template_vars['{color}']
And below that line add this piece of code:

/* MK-VISION.CZ BANKWIRE MAIL VARIABLES */
$template_vars['{bankwire_owner}'] = Configuration::get('BANK_WIRE_OWNER');
$template_vars['{bankwire_details}'] = nl2br(Configuration::get('BANK_WIRE_DETAILS'));
$template_vars['{bankwire_address}'] = nl2br(Configuration::get('BANK_WIRE_ADDRESS'));
I have tested it with Prestashop 1.6.1.3. Let me know if that helped.

Have a nice day.

Thanks!

[Betafer]

Thank you !

[Progi1984]

The bugfix seems good. We are open to pull request @Betafer ;)

[Betafer]

Thank you so much !

[maofree]

hi
you can use this hook to add new extra variables from ps_wirepayment
actionGetExtraMailTemplateVars

[Gipielle]

The bugfix seems good. We are open to pull request @Betafer ;)

Updating to 1.7.6.6 cause again the error

[bodi000]

Hello,

Sorry to come late, I thought I have the same problem, and I ended up here...
There is no bug, everything works as it should, with one condition:
generate emails for current theme in each language needed!! It was said before, but not done apparently..

regards

[maofree]

hi
can you explain more this point? generate emails for current theme
what do you mean?

[bodi000]

it is a standard feature. This discussion is for a forum, not github...

Admin>Design>Email theme >Generate emails.

Have a look, it takes 2 minutes, just be sure you don't overwrite templates
if you work with modified messages which are not in the core, they would
get overwritten. test the variants ...

enjoy

On Tue, 15 Sep 2020 at 14:59, maofree [e-mail] wrote:

hi
can you explain more this point? generate emails for current theme
what do you mean?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PrestaShop/PrestaShop/issues/18541#issuecomment-692697070,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAZXNGM32LJ3GHKDOGOL53SF5QJ3ANCNFSM4MES5G3Q
.

--
Bogdan Stanciu

[PierreRambaud]

Since we are not able to reproduce and as @bodi000 says, you can regenerate emails in Admin>Design>Email theme >Generate emails. I'm closing this issue.