Prestashop: Bug when adding more than 600 characters in message block

Created on 6 Mar 2020  ·  9Comments  ·  Source: PrestaShop/PrestaShop

On the order page, we have this text displayed on top of the page when adding more than 600 chars in the message block :
<h1 class="d-inline"> <strong class="text-muted">#5</strong> <strong>KHWLILZLL</strong> </h1> <p class="lead d-inline"> from John DOE </p> <span class="badge rounded badge-dark ml-2 mr-2 font-size-100"> 20,90 € </span> <p class="lead d-inline"> 2020-02-28 <span class="text-muted"> at 17:15:36 </span> </p>

1.7.7.x Bug Minor Order PM ✔️ PR available Regression migration

Most helpful comment

Hi @zuk3975,

On 1.7, you can predefine order messages to 1200 and send them. They are correctly displayed in BO as well as FO. Likewise, for customer service pages, merchants do not have any character limitations. Once a message is sent from the customer service page, they are displayed correctly in FO and order messages bloc.

So the harmonization of the content limitation between the order page, the customer service page and the order messages can wait until all pages are completely migrated. That is probably at the next release.

In the meantime, confirmed with @colinegin, we can increase the limitation on the order page to 1200 char to align with the predefined order messages page. Doing the opposite would cause a regression by aligning both pages at 600.

All 9 comments

Hi @colinegin,
I tried to reproduce this bug but it seems impossible to add more than 600 characters, the input blocks adding more characters, so how did you manage to add more than 600?

Capture d’écran 2020-03-18 à 11 06 19

Also do you have a screenshot of the bug? Thank you

I can try to reproduce it, but what you can try is use a predefined message and then copy paste it a few times, and it this case you should be able to add more than 600 characters. Otherwise, by just writing text, indeed you are blocked when reaching the max limit.

I agree with the fact that it is not always reproducible and that you need copy-paste to see the error
image

Thanks for the screenshot @arouiadib ;)

Couldn't reproduce it nor by writing manually nor by pasting, however I noticed the following inconsistency:
Predefined message (when editing in sell/customer-service/order-messages) allows to fill up to 1200 characters, but here in order message its limited to 600. We must equalize these numbers IMO., someone just needs to decide to leave 600 or 1200

After more investigation, let me be more precise about how to reproduce this bug :

  • copy paste a few times a preset message - indeed the block seems to be blocking the number of characters
  • save
  • check in the header, you have the error message as on @arouiadib's screenshot.

About your 2nd comment, you're right @zuk3975, let's be more consistent. I would recommend to accept 600 characters everywhere, but what would happen to merchants who had messages with more characters and update to 177 ?

Hi @zuk3975,

On 1.7, you can predefine order messages to 1200 and send them. They are correctly displayed in BO as well as FO. Likewise, for customer service pages, merchants do not have any character limitations. Once a message is sent from the customer service page, they are displayed correctly in FO and order messages bloc.

So the harmonization of the content limitation between the order page, the customer service page and the order messages can wait until all pages are completely migrated. That is probably at the next release.

In the meantime, confirmed with @colinegin, we can increase the limitation on the order page to 1200 char to align with the predefined order messages page. Doing the opposite would cause a regression by aligning both pages at 600.

fix in #18326

Fixed by #18326

Was this page helpful?
0 / 5 - 0 ratings