Prestashop: Duplicate order reference for different order 2/2

Created on 23 Oct 2018 · 91Comments · Source: PrestaShop/PrestaShop

For the second time we have a duplicate reference for two different orders, the first time both orders were created at the very same time, the second time the orders were created with 1 second difference.

Describe the bug
A clear and concise description of what the bug is.

So far it happened twice within a month or so, with hundreds of orders created just fine. We are unable to find out why so there are no steps to reproduce this at the moment, sorry.

Different order, same reference, different customer, different cart, same (or very close) date_add:

"id_order";"reference";"id_customer";"id_cart";"invoice_date";"date_add"
"1125";"C18101001125";"143131";"6367";"2018-10-10 22:06:36";"2018-10-10 22:06:36"
"1126";"C18101001125";"143130";"6372";"2018-10-10 22:06:36";"2018-10-10 22:06:36"
"2745";"C18102102744";"94587";"15912";"2018-10-21 21:01:59";"2018-10-21 21:01:59"
"2746";"C18102102744";"62536";"15904";"2018-10-21 21:02:00";"2018-10-21 21:02:00"

Additionnal information
PrestaShop version: 1.7.4.0
PHP version: 7.0

https://github.com/PrestaShop/PrestaShop/issues/11115#issuecomment-466052440

the source code is very simple for understand the problem :

public static function setLastInvoiceNumber($order_invoice_id, $id_shop)
    {
        if (!$order_invoice_id) {
            return false;
        }

        $number = Configuration::get('PS_INVOICE_START_NUMBER', null, null, $id_shop);
        // If invoice start number has been set, you clean the value of this configuration
        if ($number) {
            Configuration::updateValue('PS_INVOICE_START_NUMBER', false, false, null, $id_shop);
        }

        $sql = 'UPDATE `'._DB_PREFIX_.'order_invoice` SET number =';

        if ($number) {
            $sql .= (int)$number;
        } else {
            $getNumberSql = '(SELECT new_number FROM (SELECT (MAX(`number`) + 1) AS new_number
                FROM `'._DB_PREFIX_.'order_invoice`'.(Configuration::get('PS_INVOICE_RESET') ?
                ' WHERE DATE_FORMAT(`date_add`, "%Y") = '.(int)date('Y') : '').') AS result)';
            $getNumberSqlRow = Db::getInstance()->getRow($getNumberSql);
            $newInvoiceNumber = $getNumberSqlRow['new_number'];
            $sql .= $newInvoiceNumber;
        }

        $sql .= ' WHERE `id_order_invoice` = '.(int)$order_invoice_id;

        return Db::getInstance()->execute($sql);
    }

SELECT (MAX(number) + 1)

https://github.com/PrestaShop/PrestaShop/issues/11115#issuecomment-466335070

SELECT (MAX(`number`) + 1)

I see, so this is a race condition where two orders may get the same id. Nice find!

1.7.4.0 1.7.5.1 BO Bug Major Order To Do Topwatchers

Source

bm-services

Most helpful comment

In my case no CSV import, just a PS 1.7.5 shop migrated from 1.6. Orders with a duplicated ref are "created" by customers (not by an admin in BO) with the traditional checkout and with usual carriers and payment methods.

Klemart3D on 26 Jun 2019

👍2

All 91 comments

Hi @bm-services,

I did not manage to reproduce the issue with the last version 1.7.4.3.
I have different orders created in the very close date_add
I attached a screenshot.

Thanks to check & feedback.

khouloudbelguith on 23 Oct 2018

👍1

I have the same exact problem, posted it on PS forum aswell https://www.prestashop.com/forums/topic/934098-1742-duplicate-order-code/

schermata 2018-11-06 alle 10 35 17

schermata 2018-11-06 alle 10 35 41

schermata 2018-11-06 alle 10 38 27

SOFTWARE VERSION:

Prestashop: 1.7.4.2 (migrated form an old 1.6.x if it can help understand something with MigrationPro)

Theme: warehouse 4.1.7

Nexi XPay: 3.1.0 from "Nexi Payments SpA"

COD+: 1.5.9 from "PrestaHost.eu"

PayPal: 4.4.2 from "Prestashop"

sirion89 on 6 Nov 2018

Hi @sirion89,

I used also the COD payment module provided by Prestashop but I did not manage to reproduce the issue.

Have you tried to contact the module author?
You can contact the developer of this module PayPal here: https://www.202-ecommerce.com/en/partners-modules/technical-support/
Thanks!