Prestashop: ps_mailalerts new order notification - logic for displaying customized products is broken

[Hlavtox]

To Reproduce

1. Make a customizable product. A text or file field (optional customization).
2. Go to FO. Open up the product.
3. Customize it, add it to cart. - Customization A
4. Customize it again, add it to cart. - Customization B
5. Do not customize it, add it to cart.
6. Your cart - 3 products - 1 default, 2 customized.
7. Order it.

Resulting email table

• Product - Customization A + Customization B
• Product - Customization A + Customization B
• Product - Customization A + Customization B

Why is it wrong - ps_emailalerts.php (lines 300-320)

foreach (product in order) {
    if (product ID found in customized datas) {
        foreach (customization for this product id) {
            // echo customization
        }              
    }
}

Additional information
PrestaShop version: 1.7.6.1

[khouloudbelguith]

Hi @Hlavtox,

Thanks for your report.
I manage to reproduce the issue with PS1.7.6.1 & ps1.7.5.2 & Mail alerts v2.1.1.

I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

[Hlavtox]

@khouloudbelguith @matks Hi guys, made a PR to fix this problem. Check it out.

https://github.com/PrestaShop/ps_emailalerts/pull/28

[khouloudbelguith]

Hi,

In the BO, it is OK

Thanks!