Prestashop: Creating useless comments when using ajax to refresh the address form in checkout

[matks]

Describe the bug
On checkout page, for a shop with multiple countries available, you can use the country dropdown to select your country. When you do so, an ajax request is performed to /order?ajax=1&action=addressForm. This returns the updated HTML form which is then inserted into the checkout page.

But when it does so, it does replace everything. So if you perform this dropdown multiple times you see the template grow bigger and bigger 😄.

To Reproduce
Steps to reproduce the behavior:

1. Setup a shop using develop branch, enable at least 2 countries from BO. You need to be able to choose a country in the checkout page.
2. Go to checkout page, so for a French shop it is /commande
3. Have a look at HTML section checkout-addresses-step it looks like this

1. Choose another country. It refreshes the form. Do this multiple time. Look again at HTML section checkout-addresses-step. Now it looks like this 😄

Additional information
PrestaShop version: develop
PHP version: php7.2

[matks]

It's harmless because it's only html comments. But it's not very clean either.

[PierreRambaud]

These comments came from the debug mode to help developers to create themes and are not displayed in production. Because a comment could not be selected with selectors I'm not sure we're able to do something :/

[matks]

These comments came from the debug mode to help developers to create themes and are not displayed in production.

Considering this, then this is 100% harmless

[khouloudbelguith]

Hi @matks,

I have the same issue with develop branch.
With PS1752, it is OK.
Thanks!

[marionf]

@matks Is it a regression of 1.7.6.0 ?
If yes, we should add it to the 1.7.6 backlog

[matks]

@matks Is it a regression of 1.7.6.0 ?
If yes, we should add it to the 1.7.6 backlog

I dont know, but anyway this is really harmless. Nothing bad can come of it, it's just a "clean code" issue.

[PierreRambaud]

Yes, this is really harmless. In fact, as I understand, we use the replaceWith jquery function (https://github.com/PrestaShop/PrestaShop/blob/develop/themes/classic/_dev/js/listing.js#L153) with the new content:

<!-- begin my-template.tpl -->
<div id="content">blabla</div>
<!-- end my-template.tpl -->

because comments are not selected, it's added again, and again, each time we use this kind of replacement.

[PierreRambaud]

@marionf @khouloudbelguith I'm able to reproduce the bug in 1.7.5.2, so this is not a regression and I think can be remove from 1.7.6 backlog

[matks]

I close as I think it's insignificant