Prestashop: [BOOM-4929] Order message UTF8 problem

Created on 22 Aug 2018 · 23Comments · Source: PrestaShop/PrestaShop

This issue has been migrated from the Forge. Read the original ticket here.

_Reporter:_ RichardSon
_Created at:_ Sat, 24 Feb 2018 20:32:59 +0100

I found problem at older and new prestashop 1.7 versions also.

Order message which is added by customer on delivery step not working correctly with UTF8.

When i want use for example this message :

"áno mám sa dobre" Then in ps_message is inserted this "áno mám sa dobre" so when i will return from payment step to delivery step then prestashop return that wrong message.

How to reproduce the issue ?

Create new order and use my message as order message.

problem

1.7.4.2 1.7.6.0 Bug Checkout FO Fixed Minor PR available Topwatchers

Source

prestonBot

All 23 comments

This comment has been migrated from the Forge. Read the original comment here.

_Author:_ khouloud.belguith
_Created at:_ Mon, 26 Feb 2018 09:39:06 +0100

Hi Richard,

I manage to reproduce the issue with the last version: 1730-rc1.
We will see how to fix it.

Best regards, Khouloud

prestonBot on 22 Aug 2018

Hi, I've solved this problem with overload the CheckoutSessionCore class.

class CheckoutSession extends CheckoutSessionCore
 {

public function setMessage($message)
 {
 $this->_updateMessage($message);

return $this;
 }

private function _updateMessage($messageContent)
 {
 if ($messageContent) {
 if ($oldMessage = Message::getMessageByCartId((int)$this->context->cart->id)) {
 $message = new Message((int)$oldMessage['id_message']);
 $message->message = $messageContent;
 $message->update();
 } else {
 $message = new Message();
 $message->message = $messageContent;
 $message->id_cart = (int)$this->context->cart->id;
 $message->id_customer = (int)$this->context->cart->id_customer;
 $message->add();
 }
 } else {
 if ($oldMessage = Message::getMessageByCartId($this->context->cart->id)) {
 $message = new Message($oldMessage['id_message']);
 $message->delete();
 }
 }

return true;
 }

}

Sorry for my bad english !

Best regards, Batsare

Batsare on 9 Nov 2018

Hi @Batsare,

Would you be willing to make a pull request on GitHub with your code suggestion?
https://github.com/PrestaShop/PrestaShop/tree/develop
Thank you!

khouloudbelguith on 9 Nov 2018

Hi @khouloudbelguith,

Currently,I haven't time, but I will try to do it later.

Batsare on 9 Nov 2018

👍1

Hello,
I have the same problem, but when I copy and paste the Batsare's code that show blank screen.
Anybody Know why it can be?
Thanks!

esetieng on 30 Nov 2018

Hi,
Where did you paste the code ?
Have you enabled the overload in prestashop?

Batsare on 30 Nov 2018

Hi,
I created a new file on /override/classes/checkout / CheckoutSession.php
Is that wrong?
Thanks for your fast anwer

esetieng on 30 Nov 2018

Hi,
This is the good file...
Have you enabled the overload in Prestashop ?
Please, try clear the cache.

Batsare on 5 Dec 2018

This could be fixed without removing safeOutput function in CheckoutSession.php.

Presta developers can easily change in classes/tools.php for:

   public static function htmlentitiesUTF8($string, $type = ENT_QUOTES)
    {
        if (is_array($string)) {
            return array_map(array('Tools', 'htmlentitiesUTF8'), $string);
        }
    return htmlspecialchars((string)$string, $type, "UTF-8");

        //USE htmlspecialchars NOT htmlentities
    }