Prestashop: [BOOM-5974] Free Shipping Line Removed After Free Gift Has Been Applied

[prestonBot]

This issue has been migrated from the Forge. Read the original ticket here.

• _Reporter:_ Pentarou
• _Created at:_ Fri, 13 Jul 2018 09:49:42 +0200

In the cart and during checkout, the free shipping line is removed after applying a second free gift cart rule. This is very confusing for the customer and will certainly reduce the number of sales.

• How to reproduce the issue ?

Add cart rule free shipping from € 35,-


Add cart rule free gift to the value of € 3,95,- with every order


Add cart rule free gift to the value of € 17,95,- for orders from € 75, -

1. Add a product to the shopping cart with a value of less than 35 euros to see the shipping costs.
   
   

1. Add a product to the shopping cart with a value over 35 euros to see the free shipping label.
   
   

1. Add a product to the shopping cart so that the total value is more than or equal to 75 euros to see the shipping costs again.

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ khouloud.belguith
• _Created at:_ Fri, 13 Jul 2018 13:55:29 +0200

Hi Ferry,

Thanks for your report.
I manage to reproduce this issue with PS1.7.4.0 / 1.7.4.1-rc-1.
I attached a screen record.
1740stable.webm
We will see how to fix it.

Best regards, Khouloud

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ pentarou
• _Created at:_ Fri, 13 Jul 2018 14:10:51 +0200

Thank you kindly for your great support, Khouloud!

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ khouloud.belguith
• _Created at:_ Fri, 13 Jul 2018 14:39:37 +0200

Hi Ferry,

You are welcome.

Best regards, Khouloud

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ pentarou
• _Created at:_ Tue, 17 Jul 2018 14:45:10 +0200

Hello Khouloud,

I want to let you know that the Prestashop 1.7.4.1 upgrade seems to have resolved the problem.

 

Sincerely,

Ferry

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ marion_francois
• _Created at:_ Tue, 17 Jul 2018 16:59:45 +0200

Hello Khouloud BELGUITH

Can you confirm if you can reproduce this issue on 1.7.4.1 ?

Thanks

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ khouloud.belguith
• _Created at:_ Tue, 17 Jul 2018 17:58:22 +0200

Hi Marion F,

Yes, I manage to reproduce the issue with the last version 1.7.4.1.

Best regards, Khouloud

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ pentarou
• _Created at:_ Wed, 18 Jul 2018 11:20:33 +0200

Khouloud BELGUITH is right, I was not logged in and switched off the shipping costs for visitors. The problem still exists, sorry about that.

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ pentarou
• _Created at:_ Mon, 20 Aug 2018 16:25:41 +0200

Not to sound demanding, but how long does it take for small bugs to get fixed, there are actually three minor bugs that stop us using Prestashop 1.7.4.x, My employer asks me to upgrade almost daily. 

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ khouloud.belguith
• _Created at:_ Mon, 20 Aug 2018 16:29:04 +0200

Hi Ferry,

Sorry but you are not alone and as I said, there are more important issues to solve before this one.
We are a fairly small team (we're hiring!), and there's an insane amount of work before us. But our goal is to make each release significantly better than the one before.
So, it will probably not solved before minimum a year. But PrestaShop is an open source project, so it can be solved before if someone submits a pull request to solve it

Best regards, Khouloud

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• _Author:_ pentarou
• _Created at:_ Mon, 20 Aug 2018 16:40:02 +0200

Hi Khouloud,

Thanks for answering my question, and thank you very much for your great support, I really appreciate it. I will try to help as much as possible, but my skills are limited when it comes to coding PHP and JS.

 

Sincerely,

Ferry

[khouloudbelguith]

Hi pentarou,

Thanks!
Waiting for your feedback.

Best regards, Khouloud

[Pentarou2]

Will this bug get solved? Many of the free shipping and free gift modules that are available on the market will not fix this, so we cannot upgrade to Prestashop 1.7.x.

Thanks!

[matks]

Hi @Pentarou2,

This issue will be solved, however there's an immense amount of work to be done (1000 issues right now), and tasks take time. Oher issues have been considered, for whatever reason, more important, so they were (or are being) tackled first.

We understand that not having an issue fixed soon (or in a fixed timeframe) can be bothering, but it does not mean that it won't be fixed, or that we don't care. It doesn't mean that the issue is NOT important either.

Developer time is limited, so if the amount of issues opened in a certain timeframe exceeds the amount of issues that can be processed using the available developer time, tasks will simply pile up. This is common to ALL projects. Due to the number of pending issues, sometimes they may get lost in the pile and be forgotten about, so it's not a bad idea to ping us there from time to time, 😉 like you just did, to remind us about it, even if it's been a long while.

But here's the upside: PrestaShop is an open source, community project. If you find that any issue is critical for you, and it's important to have it fixed ASAP, then you can _invest_ into having it done. You can hire a developer to fix it, or if you are a developer yourself, you can try doing it on your own. The most important thing is to share that fix with everyone by submitting a Pull Request -- that's what the open source spirit is all about.

[arouiadib]

Hi,

The issue (as described in first comment) is not reproducible in develop for me. But there is another issue with the same scenario. So either the original issue was fixed in the past, or the title is misleading.

In fact, the shipping cost is always displayed in subtotals , in all @pentarou2 steps. The problem is in the calculation of Total. It will hopefully be fixed by @atomiix PR ( @atomiix Please to take a look at my review to see if this solution integrates well with the objective of yours. Thank you in advance).

step 1

step 2

step 3

Here is the screeshot of cart rules:

With regards

[khouloudbelguith]

Hi @arouiadib,

Thanks for your feedback.
Following these steps:
In the BO:

1. Add cart rule free shipping from € 35,-
2. Add cart rule free gift to the value of € 3,95,- with every order
3. Add cart rule free gift to the value of € 17,95,- for orders from € 75, -

In the FO:

1. Add a product to the shopping cart with a value of less than 35 euros to see the shipping costs.
2. Add a product to the shopping cart with a value over 35 euros to see the free shipping label.

The shipping cost is always displayed with develop branch

https://drive.google.com/file/d/1kCwwMtFgn6x13p9T6x88BimvF8UV7Tew/view

It is a regression in develop branch, In PS1.7.6.2 => OK
PS: Add a product to the shopping cart so that the total value is more than or equal to 75 euros to see the shipping costs again.=> reproduced with PS1.7.6.2.
In the develop branch: the shipping cost is always displayed.
Ping @atomiix, we should check this regression if it is fixed by your PR: https://github.com/PrestaShop/PrestaShop/pull/16724

Thanks!

[khouloudbelguith]

Hi @colinegin,

So to conclude in this issue we have 3 points

• A major issue is fixed in the 177x branch (reproduced in the 1752 and PS1764)

Steps to reproduce the fixed issue in the branch 177x
In the BO:

1. Add cart rule free shipping from € 35,-
2. Add cart rule free gift to the value of € 3,95,- with every order
3. Add cart rule free gift to the value of € 17,95,- for orders from € 75, -
   In the FO:
4. Add a product to the shopping cart with a value of less than 35 euros to see the shipping costs.
5. Add a product to the shopping cart with a value over 35 euros to see the free shipping label.
6. Process to checkout => at the Shipping method step => we don't have any carrier displayed => NOK
   
   Fixed in the branch 177x
   

• A minor regression in the branch 177x ( it is ok with PS1.7.6.4 and PS1.7.5.2)
  > Steps to reproduce the fixed issue in the branch 177x
  In the BO:
  >1. Add cart rule free shipping from € 35,-
  >2. Add cart rule free gift to the value of € 3,95,- with every order
  >3. Add cart rule free gift to the value of € 17,95,- for orders from € 75, -
  >4. All carriers should not be free
  In the FO:
  >1. Add a product to the shopping cart with a value of less than 35 euros to see the shipping costs.
  >2. Add a product to the shopping cart with a value over 35 euros to see the free shipping label.

at this step, in the cart details, the shipping cost is always displayed with 177x branch, in the PS1.7.6.4, it is free
177x branch

1764

• The original issue is reproduced in the PS1.7.6.4 and 177x branch
  >Steps to reproduce
  In the BO
  >1. Add cart rule free shipping from € 35,-
  >2. Add cart rule free gift to the value of € 3,95,- with every order
  >3. Add cart rule free gift to the value of € 17,95,- for orders from € 75, -
  >4. all carriers should be not free
  In the FO
  > 1. Add a product to the shopping cart with a value of less than 35 euros to see the shipping costs.
  > 2. Add a product to the shopping cart with a value over 35 euros to see the free shipping label.
  > 3. Add a product to the shopping cart so that the total value is more than or equal to 75 euros to see the shipping costs again.
  

So we need to fix the regression in the 177x branch? is it?

Thanks!

[colinegin]

If I understand correctly the last point, it's actually only a display issue as the shipping discount is correctly included in the total discount (3,95 + 17,5+12 = 33,90).

What should be done is to display FREE on the shipping line instead of the initial pricen when there is a free shipping voucher. --> this was the behaviour in 1.7.6.4 so it should be fixed.

About the initial issue "Free shipping line removed after free gift has been applied", it's not a regression as the problem was already present in 1.7.4 and 1.7.5. So we should fix it but not in 1.7.7.

Am I correct @khouloudbelguith ?
Is there already an issue about the regression ?

Thanks !

[khouloudbelguith]

Hi @colinegin,

I just mentioned the first issue as a regression:

_What should be done is to display FREE on the shipping line instead of the initial pricen when there is a free shipping voucher. --> this was the behaviour in 1.7.6.4 so it should be fixed._

Is there already an issue about the regression ?

No, it is mentioned here, in this ticket, I need to create an issue?

Thanks!

[colinegin]

Yes i think it will be easier to manage these 2 different issues separatly !
Thanks :)

[khouloudbelguith]

@colinegin, Done https://github.com/PrestaShop/PrestaShop/issues/18533 :wink:

[colinegin]

Thanks so much :)

[hibatallahAouadni]

Hello @marionf & @khouloudbelguith

This issue has been fixed with PS1.7.7.0-rc.1+build.4, see the attached screen record below:

https://drive.google.com/file/d/1KmUN4af7WKIGAM1cZiGrsncobaRi7bs3/view

Please check and feedback, so we can close it as fixed.

Thanks!

[khouloudbelguith]

Hi @hibatallahAouadni,

Yes, I did not manage to reproduce the issue with the 177x branch also!
https://drive.google.com/file/d/1dPxSsFNxS4BXXDECQCEeRbDDqnBq6GeE/view?usp=sharing

Thanks!