While adding the theme selection to PT Runs' settings (#7355), we (@davidegiacometti and I) have seen that the color setting has different namings on different settings pages.
These titles needs to be uniformed.
General / Shortcut Guide
PT Run (work in progress)
The Windows Settings using the word "color".
Because of this I think on the general page the string Settings theme
should be renamed to Choose settings color
.
Then we get a unified naming on all pages.
Thanks for flagging, it should indeed be consistentand is a very easy fix.
I know Windows uses 'Color', which is strange. 'Theme' would be more appropriate, but is taking by Windows Themes.
'Mode' sounds reasonable to me as well - similar to what the Weather app uses:
@niels9001
Yes mode is a good word too.
But the question is would you associate the word mode
withe the color settings?
Funny cause VS Code uses the word "Theme" heavily.
Wwe need to consolidate the general setting selection as well. Either that is only for Shortcut guide or we use it all a global PT Setting. I feel like we should pull this out and do it at a per-app level.
"Color mode"
Funny cause VS Code uses the word "Theme" heavily.
Wwe need to consolidate the general setting selection as well. Either that is only for Shortcut guide or we use it all a global PT Setting. I feel like we should pull this out and do it at a per-app level.
"Color mode"
- Light
- Dark
- Windows default
Yes we should also consolidate the text on general settings page. And yes per-app level is a good idea.
The setting on general page is only for the settings itself and for KBM, which is a settings window in my opinion.
But how do we mark the setting on general page as settings app related if we only call it color mode
?
I like your text suggestion "Color mode".
What about using "System setting" instead of "Windows default". - This is not the default settings of windows. It's the actual setting of windows.
Color mode
- Light
- Dark
- System setting
I take back my statement, follow UWP guidelines
@htcfreek Nice find! To conclude, the new naming for all modules will be:
"Choose a mode"
and will add a "Windows color settings" hyperlink.
I can pick this up, easy fix.
@htcfreek Nice find! To conclude, the new naming for all modules will be:
"Choose your mode"
and will add a "Windows color settings" hyperlink.
I can pick this up, easy fix.
I think "Choose a mode" is better and in line with the guidelines.
@htcfreek Nice find! To conclude, the new naming for all modules will be:
"Choose your mode"
and will add a "Windows color settings" hyperlink.
I can pick this up, easy fix.I think "Choose a mode" is better and in line with the guidelines.
Whoops, sorry.. typo. You're right. Corrected.
@crutkas
I think @niels9001 can start implementing the necessary changes. Right?
@htcfreek Nice find! To conclude, the new naming for all modules will be:
"Choose your mode"
and will add a "Windows color settings" hyperlink.
I can pick this up, easy fix.I think "Choose a mode" is better and in line with the guidelines.
It depends on the OS language:
It literally says "Choose your color" 馃え
_(this is the Windows setting, to be clear)_
Or should I report this via the Feedback Hub as an "incorrect translation"?
Added in 0.25. https://github.com/microsoft/PowerToys/releases/tag/v0.25.0
Most helpful comment
@htcfreek Nice find! To conclude, the new naming for all modules will be:
"Choose a mode"
and will add a "Windows color settings" hyperlink.
I can pick this up, easy fix.