Powertoys: [FZ Editor] GridResizer is not centrally aligned

Created on 6 Apr 2020  路  9Comments  路  Source: microsoft/PowerToys

Steps to reproduce

Use the FancyZones grid editor.

Expected behavior

The GridResizer thumbs should be horizontally and vertically aligned with the zone.

Actual behavior

The GridResizers are added, but should have a negative Left (horizontal) or Top (vertical) margin so they are in the center of the zone. This results in a bad visual representation where the zone label and GridResizer are not aligned.

Screenshots

Annotation 2020-04-06 232708

Area-Quality FancyZones-Editor Help Wanted-Good first issue

All 9 comments

Feel like this is is an easy fix

There is a reason for the current behavior, the fix should take in consideration cases like the 4 zones grid:

image

Is it possible to detect when we overlap then do the shift?

https://github.com/microsoft/PowerToys/issues/2278 maybe this will help a lot on this.

I would like to take a look at this, this would be my first issue

I would also like to contribute. chenac64 and I would be working together on this. We will try to get this completed by 6/13/20.

Per @enricogior, i don't know if the current layout will be the best route here due to the overlap issue he outlined.

https://github.com/microsoft/PowerToys/issues/1032#issuecomment-626041614 shows a possible new direction for the editor which would solve the issue by just removing the thumbnails entirely and treating the entire edge like the edge on a window.

Understood, thank you. We will look for another issue to work on.

One possible solution for the current UI, would be to reshape the gridresizer into a wide rectangle shape as in https://github.com/microsoft/PowerToys/issues/1032#issuecomment-626041614
In that case, even if two gridresizers overlap, they would still be usable.
Since we don't know when we will redesign the editor, this fix would still be welcomed and also a good opportunity to experiment with the existing code.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

amorenew picture amorenew  路  3Comments

niels9001 picture niels9001  路  3Comments

Kazamario picture Kazamario  路  3Comments

Martin-Hausleitner picture Martin-Hausleitner  路  3Comments

seritools picture seritools  路  3Comments