Powertoys: PowerPreview icon for the Settings page is not in SVG format

Created on 24 Mar 2020  路  6Comments  路  Source: microsoft/PowerToys

The pt-power-preview should be loaded from an SVG icon and not from the fabric library
https://github.com/microsoft/PowerToys/blob/badcccab762c36eaf0d918bb48e646c79089c335/src/settings-web/src/setup_icons.tsx#L20
The change that needs to be rolled back was made in this commit https://github.com/microsoft/PowerToys/commit/83ce8a2197f831708bc6116ba47c8d9fc476add6#diff-21ef5fe1a6f7848a6e9f125b5d8e6303

Check this PR to see how it should be done https://github.com/microsoft/PowerToys/pull/1662/files

Area-Quality Product-File Explorer Resolution-Fix-Committed

Most helpful comment

SVG data:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 2048 2048" width="32" height="32">
  <path d="M2048 512v256h-128V512h-704q-56 0-90 9t-58 24-41 31-37 31-50 23-76 10H128v896h128v128H128q-27 0-50-10t-40-27-28-41-10-50V256q0-27 10-50t27-40 41-28 50-10h736q37 0 69 13t58 36 49 51 39 59q13 23 25 41t28 30 35 19 49 7h704q27 0 50 10t40 27 28 41 10 50zm-1184 0q27 0 45-9t35-22 34-28 39-28q-15-17-31-45t-36-56-40-48-46-20H128v256h736zM384 896h1664v1152H384V896zm1536 1024v-896H512v896h1408zm-128-768v128h-384v-128h384zm-128 256v128h-256v-128h256zm0 256v128h-256v-128h256zm-384-512v640H640v-640h640zm-128 512v-384H768v384h384z" />
</svg>

All 6 comments

SVG data:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 2048 2048" width="32" height="32">
  <path d="M2048 512v256h-128V512h-704q-56 0-90 9t-58 24-41 31-37 31-50 23-76 10H128v896h128v128H128q-27 0-50-10t-40-27-28-41-10-50V256q0-27 10-50t27-40 41-28 50-10h736q37 0 69 13t58 36 49 51 39 59q13 23 25 41t28 30 35 19 49 7h704q27 0 50 10t40 27 28 41 10 50zm-1184 0q27 0 45-9t35-22 34-28 39-28q-15-17-31-45t-36-56-40-48-46-20H128v256h736zM384 896h1664v1152H384V896zm1536 1024v-896H512v896h1408zm-128-768v128h-384v-128h384zm-128 256v128h-256v-128h256zm0 256v128h-256v-128h256zm-384-512v640H640v-640h640zm-128 512v-384H768v384h384z" />
</svg>

@enricogior @crutkas @ryanbodrug-microsoft Is this is a ship blocker for 0.16 release ? If yes then I will assign to myself and prioritize to fix it today.

if you have the SVG data here, any reason why this isn't a quick/easy fix?

if you have the SVG data here, any reason why this isn't a quick/easy fix?

To replace the icon with Svg should be a pretty easy fix although there are bunch of files that needs to revert back. I will go ahead make those changes.

Replacing the icon is simple.
Reverting the changes to the setting-web files is not trivial, so let's get the icon in SVG for 0.16 and let's revert the other changes in 0.17 if we decide they have to be done (we might keep those changes since we ill move to Settings v2 anyway).

The fix is now available in 0.16 https://github.com/microsoft/PowerToys/releases

Was this page helpful?
0 / 5 - 0 ratings