Powertoys: Getting ImageResizer code base with code analysis

[crutkas]

https://github.com/microsoft/PowerToys/tree/dev/imageResizer

• [x] Upgrade to .NET 4.7.2 to match existing code base on ImageResizer
• [x] Upgrade to .NET 4.7.2 to match existing code base on ImageResizerTest
• [x] Add StyleCop on ImageResizer
• [x] Add StyleCop on ImageResizerTest
• [x] Add Code analysis with ruleset.set on ImageResizer w/ globalsupression.cs
• [x] Add Code analysis with ruleset.set on ImageResizerTest w/ globalsupression.cs
• [x] Fix all warnings and messages
• [x] Add clangformat from main repo on ShellExtensions
• [x] all unit tests pass
• [x] 🤘🤘

[crutkas]

@ryanbodrug-microsoft i did a push, think i got all warnings, however the tests don't want to seem to actually run.

we also should mimic the clang stuff we're doing in the main repo

assign to whomever.

[crutkas]

[crutkas]

xref #53

[arjunbalgovind]

@crutkas It looks like the unit tests weren't running as the xunit.runner.visualstudio NuGet package wasn't added to the project dependencies, and Visual Studio doesn't run xunit tests unless this adapter is installed. Adding it results in all the tests passing on the initial version of the code. I'll verify if they pass after the changes that were made above.

Edit: They pass in the latest version as well if the same change is made. Should I push the changes in the .csproj file to this branch directly or through a pull request?

[crutkas]

Just check it in to that branch right now. We will do a more formal review for the actual module integration

[arjunbalgovind]

@crutkas The clangformat file gets automatically detected by Visual Studio if it is in the same git source tree. I've formatted the files in ShellExtensions using the clang file. All unit tests pass as well.
There are still a couple of warnings on the C++ side but they seem to be related to "Return value ignored" in some LoadString function calls and "enum type unscoped" for some enum type which is defined in a library header file, so it can't be fixed. If these warnings can be left as is then this issue can probably be closed.

[crutkas]

@arjunbalgovind is there a way to suppress them with that reasoning? I know in c# you can for code analysis

[crutkas]

• do that then close :)

[arjunbalgovind]

Suppressed those warnings using the #pragma warning(suppress) directive, which suppresses it for one line of code.
Closing the issue as all the points are completed.
🤘🤘

[crutkas]

Where is the associated PR?

[arjunbalgovind]

@crutkas I checked in the changes directly to the dev/imageResizer branch. Should I revert my last few commits and add it as a PR to this branch instead?

[crutkas]

you should be in the imageResizer branch, i just expected work to come in as a PR so the work has review. If Ryan or someone reviewed it, I'm good.

[ryanbodrug-microsoft]

Sorry Guys,

I glanced over the lack of PR, because I only saw the ‘closed’ item in my outlook. @Arjun [e-mail], as discussed can you please create a PR (or point me to it if you have one), so that I can review.

--Ryan

From: Clint Rutkas [e-mail]
Sent: Monday, January 6, 2020 5:36 PM
To: microsoft/PowerToys [e-mail]
Cc: Ryan Bodrug [e-mail]; Mention [e-mail]
Subject: Re: [microsoft/PowerToys] Getting ImageResizer code base with code analysis (#1041)

Closed #1041https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F1041&data=02%7C01%7Cryanbod%40microsoft.com%7Cd25c39f57825436eecd008d79311fba6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637139577762022135&sdata=EWINfeEfDFCTpq%2BN2qXV1NohPn5TDYtDRaNL1NTPZLU%3D&reserved=0.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerToys%2Fissues%2F1041%3Femail_source%3Dnotifications%26email_token%3DANNVUNLIKSVQYU25H3AYZKTQ4PMA3A5CNFSM4KCQO5J2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVZUSZTI%23event-2926128333&data=02%7C01%7Cryanbod%40microsoft.com%7Cd25c39f57825436eecd008d79311fba6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637139577762022135&sdata=kjcvGBMT0jKhJZomItFecmyLJCKomfrVOWXVZENww4I%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANNVUNP3GXJ3AKFRHEZWRNLQ4PMA3ANCNFSM4KCQO5JQ&data=02%7C01%7Cryanbod%40microsoft.com%7Cd25c39f57825436eecd008d79311fba6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637139577762032131&sdata=jQ2VrrrkSrY1j9A2E5HRkIOoeix3%2FgOMa84zg9ucmeg%3D&reserved=0.

[arjunbalgovind]

Discussed with Ryan, he will be reviewing the changes offline. I'll make sure to use PRs for all future changes.