Powerlevel10k: Cannot exit zsh with Ctrl-D when using instant prompt

[romkatv]

See https://www.reddit.com/r/zsh/comments/dk53ow/new_powerlevel10k_feature_instant_prompt/f4ccwba/.

[MichaelAquilina]

without instant_prompt;

[[ -o ignore_eof ]] && echo "ignore_eof set" || echo "ignore_eof unset"
ignore_eof unset

with instant_prompt

[[ -o ignore_eof ]] && echo "ignore_eof set" || echo "ignore_eof unset"
ignore_eof unset

looks to be exactly the same

[MichaelAquilina]

Pressing ctrl+D after waiting around 10 seconds still shows the same issue

I keep my zshrc here if you are curious to take a peek about anything that could be interfering:
https://github.com/MichaelAquilina/swayconfig/blob/2000a7ae154bb3c9092adf494a709879702c1f9b/zshrc

for the instant prompt addition I've just added the following to the very top of that file as you specified:

if [[ -r "${XDG_CACHE_HOME:-$HOME/.cache}/p10k-instant-prompt-${(%):-%n}.zsh" ]]; then
  source "${XDG_CACHE_HOME:-$HOME/.cache}/p10k-instant-prompt-${(%):-%n}.zsh"
fi

[romkatv]

Thanks, this is useful. I'll try to reproduce this with your config. Probably has something to do with zplug.

[romkatv]

Cannot reproduce, unfortunately. Here's what I've tried.

1. Type this command:

docker run -e LANG=C.UTF-8 -e TERM=xterm-256color -it --rm debian:buster bash -uexc '
  apt update
  apt install -y zsh git curl gawk sudo nano libnotify-bin
  useradd -ms /bin/zsh test
  sudo -u test git clone https://github.com/zplug/zplug ~test/.zplug
  sudo -u test curl -fsSLo ~test/config https://raw.githubusercontent.com/MichaelAquilina/swayconfig/2000a7ae154bb3c9092adf494a709879702c1f9b/zshrc
  sudo -u test tee -a ~test/.zshrc >/dev/null <<END
export LANG=${LANG@Q}
export TERM=${TERM@Q}
if [[ -r "\${XDG_CACHE_HOME:-\$HOME/.cache}/p10k-instant-prompt-\${(%):-%n}.zsh" ]]; then
  source "\${XDG_CACHE_HOME:-\$HOME/.cache}/p10k-instant-prompt-\${(%):-%n}.zsh"
fi
function xdg-settings() {}
function dircolors() { command dircolors }
source ~/config
END
  exec su - test'

1. Once prompt appears, type zplug install.
2. Type zsh. Powerlevel10k prompt appears. Hit Ctrl-D to exit.
3. Repeat step 3.
4. Type zsh. Then again zsh. Hit Ctrl-D twice to get back to the login zsh.

As you can see in the docker command, I've made a few changes to your config.

1. Export LANG and TERM. I had to set these manually because I start with clean environment.
2. Enable instant prompt.
3. Make xdg-settings a no-op. I don't have it installed and it probably doesn't matter.
4. Effectively replace dircolors ~/.dircolors with plain dircolors. I don't have ~/.dircolors. Probably doesn't matter.

Could you check whether the same thing works locally on your system?

1. Type this command. It assumes you have sudo and useradd/userdel. If not, please adjust accordingly.

() {
  emulate -L zsh
  setopt err_return no_unset
  sudo useradd -ms =zsh test
  {
    sudo -Hu test git clone https://github.com/zplug/zplug ~test/.zplug
    sudo -Hu test curl -fsSLo ~test/config https://raw.githubusercontent.com/MichaelAquilina/swayconfig/2000a7ae154bb3c9092adf494a709879702c1f9b/zshrc
    sudo -Hu test tee -a ~test/.zshrc >/dev/null <<END
export TERM=xterm-256color
if [[ -r "\${XDG_CACHE_HOME:-\$HOME/.cache}/p10k-instant-prompt-\${(%):-%n}.zsh" ]]; then
  source "\${XDG_CACHE_HOME:-\$HOME/.cache}/p10k-instant-prompt-\${(%):-%n}.zsh"
fi
function xdg-settings() {}
function dircolors() { command dircolors }
source ~/config
END
    sudo su - test
 } always {
   sudo userdel -r test 2>/dev/null
 }
}

1. Perform steps 2-5 from above.

Let me know whether this works.

P.S.

zplug likes to hang shell. E.g., if I add zplug check || zplug install to ~/.zshrc the way documentation suggests, it'll hang for good. Or if I run zplug install while having POSIX or C locale -- it'll hang for good, too. Maybe it's related.

[MichaelAquilina]

Interestingly this issue only seems to occur on kitty terminal (https://github.com/kovidgoyal/kitty). So it might potentially be a bug there.

[romkatv]

Thanks for this vital piece of information! I'll try to reproduce it with kitty tomorrow.

[romkatv]

Wasn't able to reproduce and no one else has complained. Closing. Please reopen if you are able to supple instructions that I can follow to reproduce the issue.

[romkatv]

Finally gotten down to it. Unlike all other terminals, kitty doesn't terminate until the number of open file descriptors to the TTY goes down to zero. This nasty bug is classified as feature in kitty :shrug:

I've implemented a workaround in powerlevel10k. If you update, powerlevel10k will no longer hold open file descriptors to the TTY after the parent zsh fnishes, kitty should close when you hit Ctrl-D. That is, unless something else holds open file descriptors to the TTY, which can very well be.

[MichaelAquilina]

Thanks for this @romkatv !

[nyuszika7h]

This is not specific to KiTTY. I just installed powerlevel10k from git master and I have this issue with the default Windows console (WSL), Windows Terminal, mintty/wsltty, and also when using tmux over SSH. I can't close zsh with Ctrl+D until it has finished loading.

❯ [[ -o ignore_eof ]] && echo "ignore_eof set" || echo "ignore_eof unset"
ignore_eof unset

[romkatv]

until it has finished loading

What does "finished loading" mean?

[nyuszika7h]

When the instant prompt shows up, I can't close zsh with Ctrl+D yet. But after the pyenv and rvm info shows up, it works fine.

[romkatv]

Makes sense. When instant prompt shows up, you cannot close with exit either, or run ls. Shell isn't ready to do anything yet.

This issue is about kitty not being able to be closed when pressing Ctrl-D at any time. You can reproduce it like this:

1. Configure kitty to start bash or zsh.
2. Start kitty.
3. Type sleep 3600 & disown.
4. Press Ctrl-D.
5. Kitty hangs (to be fair, kitty's developer says it doesn't hang, it just doesn't close).

There is a setting in Kitty that turns this behavior off.

Note that these steps don't depend on powerlevel10k. It's just how kitty works.

Also note that powerlevel10k no longer prevents kitty from closing.

[nyuszika7h]

Ah, I see, I misunderstood it. It's not a big deal since I don't usually want to immediately close zsh like that anyway.

[MichaelAquilina]

@romkatv I seem to be experiencing this same issue since I pulled the latest version of powerlevel10k

Confirmed this by commenting out this line:

# Enable Powerlevel10k instant prompt. Should stay close to the top of ~/.zshrc.
# Initialization code that may require console input (password prompts, [y/n]
# confirmations, etc.) must go above this block, everything else may go below.
if [[ -r "${XDG_CACHE_HOME:-$HOME/.cache}/p10k-instant-prompt-${(%):-%n}.zsh" ]]; then
#  source "${XDG_CACHE_HOME:-$HOME/.cache}/p10k-instant-prompt-${(%):-%n}.zsh"
fi

Still using the same terminal (kitty)

[romkatv]

@MichaelAquilina please describe the issue you are experiencing.

[MichaelAquilina]

It's the same one I experienced before the fix you mentioned here: https://github.com/romkatv/powerlevel10k/issues/274#issuecomment-622965319-permalink

Basically if I try to exit ((ctrl+D) or running exit), the shell stays open until I force close it with my window manager

[romkatv]

Does it help if you set close_on_child_death yes in kitty config?

See https://sw.kovidgoyal.net/kitty/conf.html#opt-kitty.close_on_child_death.

[MichaelAquilina]

Seems like that works. Should this still be considered a regression?

[romkatv]

Seems like that works. Should this still be considered a regression?

I cannot reproduce this. There is some interplay with something else you have.

What kitty does by default is absolutely awful. The config change merely makes the closing behavior sane and identical to all other terminals. At this point I don’t want to spend any more time just because kitty made a terrible choice for its default.

[MichaelAquilina]

I think that's fair enough if the workarounds introduce needless complexity. Might be worth adding something to the README as a warning to kitty users (and anyone else experiencing similiar issues) though?

[romkatv]

Not worth including anything in readme. If it was a popular or high quality terminal, things works be different.