Polaris-react: [New DL] Modal opened by contextual save bar is using inverted palette

Created on 4 Sep 2020  路  2Comments  路  Source: Shopify/polaris-react

Issue summary

A user opens a confirmation modal from the contextual save bar the colors of the modal are inverted.

Expected behavior

When a user gets a confirmation modal from the contextual save bar the color should be not inverted.

Actual behavior

image (1)

high priority 馃悰Bug

All 2 comments

With the new button changes, the secondaryAction (or discardAction button) looks inconsistent with its borders on top/bottom. This seems noticeable right now, only because the ContextualBar as well as the Modal that opens after it is dark (in dark mode?). Potentially, this will be fixed once both components are a lighter color and will not demand extra attention.

Here some screenshots for reference:

Context bar cancel button

image

Clicking on Cancel opens dark modal with same inconsistent secondary action

image

I noticed this too on the most recent changes. I believe the modal is getting the dark mode theme because it is nested within the context bar's theme provider here. I'm going to put up a PR to move that out but that doesn't solve the button issues.

Was this page helpful?
0 / 5 - 0 ratings