Polaris-react: [TextField] Max and Min have the wrong type
Issue summary
min and max should allow for number|string, not just number.
This prevents using min and max for a native date input, which is allowed.
cboltt
All 2 comments
React types JSX.IntrinsicElements['input']['max'] (and min) as number|string. I don't think we should try and be too clever here, and keep it as simple as possible by allowing number|string.
BPScott
on 19 Aug 2019
👍2
I鈥檓 going to reframe this issue as a bug fix instead of a feature request. And to build off of @BPScott鈥檚 point, I think we want to type as number|string, simply pass the string value through to the input, and let the native element handle it accordingly.
tmlayton
on 20 Aug 2019
Was this page helpful?
0 / 5 - 0 ratings
Related issues
wmceff
路
3Comments
HYPD
路
3Comments
pbojinov
路
3Comments
artyrcheek
路
3Comments
mbaumbach
路
3Comments
Most helpful comment
React types
JSX.IntrinsicElements['input']['max'](and min) as number|string. I don't think we should try and be too clever here, and keep it as simple as possible by allowingnumber|string.