Polaris-react: Banner content clarification

[caitlinmullen]

Problem

There aren't definitive guidelines around different types of content within banners (headings, body content, links), and banner content is applied inconsistently across the product.

A long-lost Slack conversation in #product-content drew attention to the issue of when it's appropriate to use just a heading, just body content, links, combinations of 2 elements, or all 3. What is the relationship between these 3 content elements within banners?

Additionally, we want to explore some scenarios in which banner content breaks the usual patterns. Usually a heading follows the short noun-verb sentence pattern, but sometimes headings are complete sentences with a period (particularly when body content is absent). Let's try to identify other patterns in banners and try to figure out when a particular style is most appropriate.

Examples

Polaris banner with just body content:

Polaris banner with heading and link:

---

Side note: This may also be a good time to explore writing more explicit guidelines for when to use certain styles of banners in less specific scenarios (i.e. banners other than critical/warning banners).

[evija]

Pings: @Shopify/product-content

[probot-shopify[bot]]

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

[virginiastart]

We should also have a pattern for what we say when a dismissible banner is dismissed. Right now, we have a few variations:

cc: @selenehinkley

[selenehinkley]

Thanks for adding to the issue, @virginiastart! For now this issue is part of the Polaris backlog so if anyone is interested in working out a pattern and contributing to the design system let me know and I can help them. In the meantime I'll be prioritizing a bigger project.

[caitlinmullen]

I'm interested in picking this up again, and I'll probably be better equipped to now that I'm actually working on Core. It might take a bit before I can give it some focused attention, but I'd be happy to collaborate (or let it go if someone else is interested in tackling this sooner).

[selenehinkley]

That would be fabulous, @caitlinmullen. @VanjaMitrovic, @sadiesaurus and I are going to start using every second Friday to do content quality assurance and you're welcome to join us if you're looking for a dedicated time to work on patterns :)

[caitlinmullen]

Sounds great, would love to join!

[probot-shopify[bot]]

This issue has been inactive for 180 days and labeled with Icebox. It will be closed in 7 days if there is no further activity.