Polaris-react: [List filters] [a11y] Accessibility review

[sarahill]

[ry5n]

@sarahill Let’s work on a short set of instructions for how to review this in Web, and what Devon should do to test it. Then we can assign to her.

[dpersing]

Currently testing on master in web with the flag on. I'm blocked on testing on Windows at the moment due to a cross-scripting issue, but I can start writing up issues that are more general.

[ry5n]

(As discussed outside of GitHub, we’re going to opt for video calls to review this together, rather than putting together instructions.)

[dpersing]

Issues have been logged in ~web~ polaris-react for items specific to the list filters rollout, and in polaris-ux for issues that are specific to existing Polaris components:

• Accordion button state: #1207
• Sheet focus management: #1208
• Filter name saving focus management: #1209
• Monochrome link focus state: #1210 and https://github.com/Shopify/polaris-ux/issues/242
• New tab/external link icon: #1211, related to https://github.com/Shopify/polaris-ux/issues/146
• Spinner not conveyed clearly: #791, #1212
• High Contrast visibility: #1213
• Toasts not conveyed clearly (originally reported as part of a separate review; I've opened these as separate issues since they weren't addressed): #1215, #1216

~Because of issues with CORS, I haven't been able to test in Windows, so it's possible there are issues that affect assistive tech users on Windows.~

All issues appear on the project board: https://github.com/Shopify/polaris-react/projects/2

I've prioritized issues related to keyboard focus management.

[ry5n]

@dpersing Do you feel satisfied with the review, enough to consider this closed?

[dpersing]

@ry5n Works for me! We can do another pass before the full launch for stragglers.