Polaris-react: [ComboBox] Keypress test suite has false positives
Issue summary
These async functions are not ever invoked, so the expect lines in them aren't ever hit.
chloerice
All 9 comments
We noticed this awhile ago although I wasn't aware the pr never shipped 馃槵 If I recall @danrosenthal mentioned previously writing up a brief to refactor AutoComplete with Tim?
AndrewMusgrave
on 5 Mar 2019
That's right @AndrewMusgrave, the issue for that is here. @tmlayton mentioned he had it nearly done in a recent chat
In the mean time, we should consider just reverting this commit: https://github.com/Shopify/polaris-react/commit/f894f347c3fd61a10519ef4078bc6bc37884ede9
danrosenthal
on 6 Mar 2019
It looks like the PR added some key handlers as well. Do we think it's more worthwhile to make all the tests run and skip ones that fail for now?
AndrewMusgrave
on 6 Mar 2019
From what I can tell, each of those cases was already handled by vanilla event handlers. Can you confirm?
danrosenthal
on 6 Mar 2019
馃憖
AndrewMusgrave
on 6 Mar 2019
It looks like the events we're previously handled however they were on the combobox opposed to document. Seems the PR may include a popover bug fix (not positive without digging into it)
AndrewMusgrave
on 6 Mar 2019
Yeah, I'd rather just fix the tests. Just need to trigger the listener component and 馃敟 the listener map mock.
chloerice
on 6 Mar 2019
I'll take a look today and see if I can refactor the breaking tests to hold us over till the autocomplete refactor
AndrewMusgrave
on 6 Mar 2019
@chloerice Sorry I totally missed the fact you assigned this to yourself 馃槰
AndrewMusgrave
on 6 Mar 2019
Related issues
vilav
路
3Comments
greghesp
路
3Comments
HYPD
路
3Comments
MateusJabour
路
3Comments
alex-page
路
3Comments
Most helpful comment
I'll take a look today and see if I can refactor the breaking tests to hold us over till the autocomplete refactor