Polaris-react: [Button] Add “pressed” state
Problem
Sometimes buttons are used like a radio button, usually in a group but potentially on their own (as a toggle).
As implemented in polaris-rails: https://github.com/Shopify/polaris-ux/issues/58
Examples
dleroux
All 7 comments
@maxariss
dleroux
on 18 May 2018
@dleroux can we close this in favour of the ToggleButton component that is currently in polaris-next?
yourpalsonja
on 18 Apr 2019
@yourpalsonja we can but this is the issue and not the pr so it should probably be closed once that that toggle buttons makes it into Polaris? Although it is a bit different. Your call :)
dleroux
on 18 Apr 2019
After a chat with @yourpalsonja, we decided to leave this issue for now and figure out how to move the ToggleButton into Polaris from Polaris-next (instead of adding a confusing prop to Button).
mirualves
on 26 Jul 2019
This work is currently on hold while the P-BOP team supports Tooling with updating the UI Kit for Figma.
dpersing
on 20 Aug 2019
Hi @AndrewMusgrave! Any updates on this issue?
dpersing
on 18 Sep 2019
@dpersing Had a slight delay, in the beginning, pinged Sonja for some information before I realized she was OOO 😅I opened a WIP draft pr (not up to date) #2148. I'm curring working on adding the pressed state for all the button types/modifiers. I'll probably be messaging @mirualves for some opinions on styles / UI kit updates Friday.
AndrewMusgrave
on 19 Sep 2019
Related issues
danrosenthal
·
3Comments
wmceff
·
3Comments
shahab65
·
3Comments
MateusJabour
·
3Comments
HYPD
·
3Comments
Most helpful comment
@dpersing Had a slight delay, in the beginning, pinged Sonja for some information before I realized she was OOO 😅I opened a WIP draft pr (not up to date) #2148. I'm curring working on adding the pressed state for all the button types/modifiers. I'll probably be messaging @mirualves for some opinions on styles / UI kit updates Friday.