Polaris-react: Missing lodash-decorators

Created on 7 May 2018  路  2Comments  路  Source: Shopify/polaris-react

Issue summary

I'de notice that you guys are using lodash-decorators without defining it in package.json, that might cause errors when bundling the app, so please add it to your package.json dependency.

Expected behavior

// src/components/AppProvider/StickyManager.ts
import {autobind} from '@shopify/javascript-utilities/decorators';
import {getRectForNode} from '@shopify/javascript-utilities/geometry';
import throttle from 'lodash-decorators/throttle';
import {
  addEventListener,
  removeEventListener,
} from '@shopify/javascript-utilities/events';

Specifications

  • Polaris version: 2.0.0-rc.3
  • React version: 16.3.2
  • Browser: Chrome
  • Device: Mac
  • Operating System: MacOS

Most helpful comment

This fix made it into the final version of v2.0.0.

All 2 comments

Thanks for the issue @paul-phan. We will get that fixed in the next release.

This fix made it into the final version of v2.0.0.

Was this page helpful?
0 / 5 - 0 ratings